Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle addExtension will add BOM dependency even if platform is already in dependencies list #11251

Closed
mgorniew opened this issue Aug 6, 2020 · 2 comments · Fixed by #11255
Closed
Assignees
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/bug Something isn't working
Milestone

Comments

@mgorniew
Copy link
Contributor

mgorniew commented Aug 6, 2020

Describe the bug
Gradle plugin from master branch will add platform BOM dependency even if enforcedPlatform is already in dependency list.

Expected behavior
Platform BOM should not be added by addExtension task, if BOM is already present.

Actual behavior
From build.gradle, after calling .\gradlew.bat addExtension --extensions="quarkus-jackson"

dependencies {
    implementation 'io.quarkus:quarkus-jackson'
    implementation 'io.quarkus:quarkus-bom:999-SNAPSHOT'
    implementation enforcedPlatform("${quarkusPlatformGroupId}:${quarkusPlatformArtifactId}:${quarkusPlatformVersion}")
    implementation 'io.quarkus:quarkus-resteasy-jsonb'
    implementation 'io.quarkus:quarkus-resteasy'
    testImplementation 'io.quarkus:quarkus-junit5'
    testImplementation 'io.rest-assured:rest-assured'
}

To Reproduce
Steps to reproduce the behavior:

  1. Create quarkus gradle project and call .\gradlew.bat addExtension --extensions="quarkus-jackson"
@mgorniew mgorniew added the kind/bug Something isn't working label Aug 6, 2020
@quarkusbot quarkusbot added the area/gradle Gradle label Aug 6, 2020
@quarkusbot
Copy link

/cc @quarkusio/devtools, @glefloch

@aloubyansky aloubyansky added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Aug 6, 2020
@gastaldi
Copy link
Contributor

gastaldi commented Aug 6, 2020

Ah that's a bug in the ExtensionManager, I'll have a look

@gastaldi gastaldi self-assigned this Aug 6, 2020
gastaldi added a commit to gastaldi/quarkus that referenced this issue Aug 6, 2020
gastaldi added a commit to gastaldi/quarkus that referenced this issue Aug 6, 2020
@gsmet gsmet added this to the 1.7.0.Final milestone Aug 7, 2020
gsmet pushed a commit that referenced this issue Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants