Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC - generate a convenient client bean to improve the user experience #17360

Closed
mkouba opened this issue May 19, 2021 · 2 comments · Fixed by #17387
Closed

gRPC - generate a convenient client bean to improve the user experience #17360

mkouba opened this issue May 19, 2021 · 2 comments · Fixed by #17387
Assignees
@mkouba
Labels
area/grpc gRPC kind/enhancement New feature or request
Milestone
2.0.0.CR1

Comments

@mkouba
Copy link
Contributor

mkouba commented May 19, 2021

Currently, a static nested class can be injected, e.g. @GrcpClient MutinyGreeterStub. We could reuse the generated service interface introduced in #17342 and allow users to inject @GrcpClient Greeter.
@mkouba mkouba added the kind/enhancement New feature or request label May 19, 2021
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label May 19, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 19, 2021

/cc @cescoffier, @michalszynkiewicz

@mkouba
Copy link
Contributor Author

mkouba commented May 19, 2021

CC @Ladicek ;-)

@mkouba mkouba mentioned this issue May 20, 2021
Merged
@mkouba mkouba self-assigned this May 20, 2021
mkouba added a commit to mkouba/quarkus that referenced this issue May 20, 2021
@mkouba
gRPC - generate a convenient Mutiny client
1d73c4e 
- implementing the service interface
- this client is injected into an injetion point with the service interface as the required type and the @GrcpClient qualifier
- resolves quarkusio#17360
- also turn the @GrpcService into a CDI qualifier (was CDI stereotype)
@mkouba mkouba mentioned this issue May 20, 2021
Merged
mkouba added a commit to mkouba/quarkus that referenced this issue May 20, 2021
@mkouba
gRPC - generate a convenient Mutiny client
6902273 
- implementing the service interface
- this client is injected into an injetion point with the service interface as the required type and the @GrcpClient qualifier
- resolves quarkusio#17360
- also turn the @GrpcService into a CDI qualifier (was CDI stereotype)
mkouba added a commit to mkouba/quarkus that referenced this issue May 20, 2021
@mkouba
gRPC - generate a convenient Mutiny client
0c5b21f 
- implementing the service interface
- this client is injected into an injetion point with the service interface as the required type and the @GrcpClient qualifier
- resolves quarkusio#17360
- also change the parameter names for streams from "hldr" to "request"
- also turn the @GrpcService into a CDI qualifier (was CDI stereotype)
mkouba added a commit to mkouba/quarkus that referenced this issue May 21, 2021
@mkouba
gRPC - generate a convenient Mutiny client
0e3b367 
- implementing the service interface
- this client is injected into an injetion point with the service interface as the required type and the @GrcpClient qualifier
- resolves quarkusio#17360
- also change the parameter names for streams from "hldr" to "request"
- also turn the @GrpcService into a CDI qualifier (was CDI stereotype)
mkouba added a commit to mkouba/quarkus that referenced this issue May 24, 2021
@mkouba @Ladicek
gRPC - generate a convenient Mutiny client
12247df 
- implementing the service interface
- this client is injected into an injetion point with the service interface as the required type and the @GrcpClient qualifier
- resolves quarkusio#17360
- also change the parameter names for streams from "hldr" to "request"
- also turn the @GrpcService into a CDI qualifier (was CDI stereotype)

Co-authored-by: Ladislav Thon <ladicek@gmail.com>
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkouba mkouba

Labels
area/grpc gRPC kind/enhancement New feature or request
Projects
None yet
Milestone
2.0.0.CR1
Development

Successfully merging a pull request may close this issue.

gRPC - generate a convenient Mutiny client mkouba/quarkus
1 participant
@mkouba