Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC - generate a convenient Mutiny client #17387

Merged
merged 1 commit into from
May 24, 2021
Merged

gRPC - generate a convenient Mutiny client #17387

merged 1 commit into from
May 24, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 20, 2021 •
edited

DRAFT because the guide is not updated yet.

@mkouba mkouba force-pushed the issue-17360 branch 2 times, most recently from 0c5b21f to 0e3b367 Compare May 21, 2021 13:23
@mkouba mkouba marked this pull request as ready for review May 21, 2021 13:23
@mkouba mkouba requested a review from Ladicek May 21, 2021 13:23
@mkouba mkouba added this to the 2.0 - main milestone May 21, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 21, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 0e3b367

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ CI Sanity Check Build ⚠️ Check → Logs Raw logs

@Ladicek
Copy link
Contributor

Ladicek commented May 21, 2021

Very nice!

@mkouba @Ladicek
gRPC - generate a convenient Mutiny client
12247df 
- implementing the service interface
- this client is injected into an injetion point with the service interface as the required type and the @GrcpClient qualifier
- resolves quarkusio#17360
- also change the parameter names for streams from "hldr" to "request"
- also turn the @GrpcService into a CDI qualifier (was CDI stereotype)

Co-authored-by: Ladislav Thon <ladicek@gmail.com>
@quarkus-bot
Copy link

quarkus-bot bot commented May 24, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building c008c72

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Reclaim Disk Space ⚠️ Check → Logs Raw logs

cescoffier
cescoffier approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!

@mkouba mkouba merged commit d9dc83f into quarkusio:main May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@cescoffier cescoffier cescoffier approved these changes

@michalszynkiewicz michalszynkiewicz Awaiting requested review from michalszynkiewicz

Assignees
No one assigned
Labels
area/documentation area/grpc gRPC
Projects
None yet
Milestone
2.0.0.CR1
Development

Successfully merging this pull request may close these issues.

gRPC - generate a convenient client bean to improve the user experience
3 participants
@mkouba @Ladicek @cescoffier