Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus.container-image.password stored in image #17519

Closed
hyperman1 opened this issue May 28, 2021 · 1 comment · Fixed by #17549
Closed

quarkus.container-image.password stored in image #17519

hyperman1 opened this issue May 28, 2021 · 1 comment · Fixed by #17549
Assignees
Labels
area/container-image kind/bug Something isn't working
Milestone

Comments

@hyperman1
Copy link

Describe the bug

I created an image with jenkins and it contains in application.properties a line:

  quarkus.container-image.password=SOME_DEV_PASSWORD

When releasing, jenkins runs the maven build with

mvn [...] -Dquarkus.container-image.password=SOME_PREPROD_PASSWORD.

When I run this release in openshift, I get the messages below, which mean quarkus stored the preprod password from the command line in the image. This has consequences for security, so I want to get rid of that.

I can hide the messages by changing application.properties like this, but this would remove only the dev password, not the preprod password. So what should I do?

 WARN  [io.qua.run.ConfigChangeRecorder] (main) Build time property cannot be changed at runtime. quarkus.container-image.tag was VERSIONNUMBER at build time and is now latest
 WARN  [io.qua.run.ConfigChangeRecorder] (main) Build time property cannot be changed at runtime. quarkus.container-image.username was USERNAME  at build time and is now OTHERUSERNAME
 WARN  [io.qua.run.ConfigChangeRecorder] (main) Build time property cannot be changed at runtime. quarkus.container-image.password was SOME_PREPROD_PASSWORD at build time and is now  SOME_DEV_PASSWORD
@hyperman1 hyperman1 added the kind/bug Something isn't working label May 28, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 28, 2021

/cc @geoand

@geoand geoand self-assigned this May 31, 2021
geoand added a commit to geoand/quarkus that referenced this issue May 31, 2021
geoand added a commit that referenced this issue May 31, 2021
Allow extensions to suppress build time config change warnings
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone May 31, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final May 31, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/container-image kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants