Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extensions to suppress build time config change warnings #17549

Merged
merged 1 commit into from
May 31, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 31, 2021

Fixes: #17519

Based on the example mentioned in that issue, with main one would see:

2021-05-31 13:56:48,133 WARN  [io.qua.run.con.ConfigChangeRecorder] (main) Build time property cannot be changed at runtime:
 - quarkus.container-image.password was 'SOME_PREPROD_PASSWORD' at build time and is now 'SOME_DEV_PASSWORD'

With this PR that warning does not appear

@quarkus-bot
Copy link

quarkus-bot bot commented May 31, 2021

Failing Jobs - Building 81a04f6

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/grpc-streaming

io.quarkus.grpc.example.streaming.StreamingEndpointTest.testSource line 23 - More details - Source on GitHub

@radcortez
Copy link
Member

One other thing to consider for #7442.

@geoand geoand merged commit c2801d4 into quarkusio:main May 31, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone May 31, 2021
@geoand geoand deleted the #17519 branch May 31, 2021 16:20
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus.container-image.password stored in image
3 participants