Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed tracing for RestEasy Reactive #17800

Closed
michalszynkiewicz opened this issue Jun 9, 2021 · 8 comments · Fixed by #18543
Closed

Distributed tracing for RestEasy Reactive #17800

michalszynkiewicz opened this issue Jun 9, 2021 · 8 comments · Fixed by #18543

Comments

@michalszynkiewicz
Copy link
Member

With RestEasy Classic we can trace the calls with Jaeger, we need the same functionality for RestEasy Reactive, both for server and client (client needs to propagate appropriate headers)

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 9, 2021

@kenfinnigan kenfinnigan added this to Backlog in Observability roadmap [Deprecated] via automation Jun 9, 2021
@kenfinnigan
Copy link
Member

I kind of have this covered as part of #17118 as well.

I know today the Reactive REST Client bit isn't there, but there should be tracing with OpenTelemetry for RESTEasy Reactive server components.

@michalszynkiewicz
Copy link
Member Author

Should we close this then and add a bullet about the client to #17118 ?

@kenfinnigan
Copy link
Member

Thinking on it more, I think it's ok for this to be open, as I know there is work needed for the client which can be added under this issue instead of the validation one.

I think I'd planned on creating issues when I find things during validation, but I know the client is missing for reactive, so this can stay

@kenfinnigan
Copy link
Member

Today I've verified the server tracing is working for RESTEasy Reactive.

It's only the client missing

@michalszynkiewicz
Copy link
Member Author

@kenfinnigan do you intend to work on it? Or should I?

@kenfinnigan
Copy link
Member

I wouldn't be getting to it until some time next week at the earliest. If you have the time it would be appreciated

@michalszynkiewicz
Copy link
Member Author

I doubt I will have time for this that soon too :) If I do, I will let you know

@kenfinnigan kenfinnigan moved this from Backlog to Current Qtr in Observability roadmap [Deprecated] Jun 30, 2021
@kenfinnigan kenfinnigan moved this from Current Qtr to In progress in Observability roadmap [Deprecated] Jul 7, 2021
kenfinnigan added a commit to kenfinnigan/quarkus that referenced this issue Jul 8, 2021
- Fixes quarkusio#17800
- Remove "hidden" opentelemetry-rest-client extension as it's no longer needed
- Prevent the VertxTracingAdaptor from creating a CLIENT span when REST Client has done it. Check for "traceparent" header in request already
- Fix RESTEasy Reactive client url template path by removing double slash
kenfinnigan added a commit to kenfinnigan/quarkus that referenced this issue Jul 9, 2021
- Fixes quarkusio#17800
- Remove "hidden" opentelemetry-rest-client extension as it's no longer needed
- Prevent the VertxTracingAdaptor from creating a CLIENT span when REST Client has done it. Check for "traceparent" header in request already
- Fix RESTEasy Reactive client url template path by removing double slash
Observability roadmap [Deprecated] automation moved this from In progress to Done Jul 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants