-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed tracing for RestEasy Reactive #17800
Comments
I kind of have this covered as part of #17118 as well. I know today the Reactive REST Client bit isn't there, but there should be tracing with OpenTelemetry for RESTEasy Reactive server components. |
Should we close this then and add a bullet about the client to #17118 ? |
Thinking on it more, I think it's ok for this to be open, as I know there is work needed for the client which can be added under this issue instead of the validation one. I think I'd planned on creating issues when I find things during validation, but I know the client is missing for reactive, so this can stay |
Today I've verified the server tracing is working for RESTEasy Reactive. It's only the client missing |
@kenfinnigan do you intend to work on it? Or should I? |
I wouldn't be getting to it until some time next week at the earliest. If you have the time it would be appreciated |
I doubt I will have time for this that soon too :) If I do, I will let you know |
- Fixes quarkusio#17800 - Remove "hidden" opentelemetry-rest-client extension as it's no longer needed - Prevent the VertxTracingAdaptor from creating a CLIENT span when REST Client has done it. Check for "traceparent" header in request already - Fix RESTEasy Reactive client url template path by removing double slash
- Fixes quarkusio#17800 - Remove "hidden" opentelemetry-rest-client extension as it's no longer needed - Prevent the VertxTracingAdaptor from creating a CLIENT span when REST Client has done it. Check for "traceparent" header in request already - Fix RESTEasy Reactive client url template path by removing double slash
With RestEasy Classic we can trace the calls with Jaeger, we need the same functionality for RestEasy Reactive, both for server and client (client needs to propagate appropriate headers)
The text was updated successfully, but these errors were encountered: