Add OpenTelemetry tracing spans for RESTEasy Reactive clients #18543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kenfinnigan
commented
Jul 8, 2021
kenfinnigan
commented
- Fixes Distributed tracing for RestEasy Reactive #17800
- Remove "hidden" opentelemetry-rest-client extension as it's no longer needed
- Prevent the VertxTracingAdaptor from creating a CLIENT span when REST Client has done it. Check for "traceparent" header in request already
- Fix RESTEasy Reactive client url template path by removing double slash
quarkus-bot
bot
added
area/dependencies
|
@kenfinnigan I'm really happy to see this :) Could you add some test for Rest Client Reactive? |
|
In the integration tests for RR? |
|
I was thinking somewhere in the integration tests in the Quarkus project. |
|
Sorry, that's what I meant. The integration tests for RR in Q |
- Fixes quarkusio#17800 - Remove "hidden" opentelemetry-rest-client extension as it's no longer needed - Prevent the VertxTracingAdaptor from creating a CLIENT span when REST Client has done it. Check for "traceparent" header in request already - Fix RESTEasy Reactive client url template path by removing double slash
kenfinnigan
force-pushed
the
otel-rest-client
branch
from
207e0aa
to
f3329f9
Compare
|
@michalszynkiewicz test added |
|
that was fast. I don't know much about opentelemetry but the parts I understand look good to me. |
michalszynkiewicz
approved these changes
Jul 9, 2021
|
@ebullient could you have a look at this one before we wrap 2.1 CR1? It looks like an interesting addition. Thanks! |
ebullient
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.