You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
only return public methods and thus when I called the Funq function I got NOT FOUND.
Expected behavior
Build should fail as it makes no sense for user to annotate the method with @Funq if it's going to be ignored.
Actual behavior
No warning is logged (that method is ignored), I also didn't find any mention of this in the docs (though it might be obvious that only public is expected...). Non-public method annotated with @Funq is not registered.
How to Reproduce?
Reproducer:
Steps to reproduce the behavior:
define non-public method annotated with @Funq
call it
Output of uname -a or ver
Linux fedora 5.19.4-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Aug 25 17:42:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Output of java -version
openjdk version "17.0.3" 2022-04-19
GraalVM version (if different from Java)
GraalVM CE 22.1.0
Quarkus version or git rev
999-SNAPSHOT
Build tool (ie. output of mvnw --version or gradlew --version)
Apache Maven 3.8.6
Additional information
I'll submit the PR for this provided there is an agreement it's a bug. I already have a validation prepared.
The text was updated successfully, but these errors were encountered:
Describe the bug
I accidentally defined
@Funq
function with friendly visibility like this:however non-public methods are ignored (which makes sense) as
clz#getMethods
herequarkus/extensions/funqy/funqy-server-common/runtime/src/main/java/io/quarkus/funqy/runtime/FunctionRegistry.java
Line 12 in 2cbd177
Expected behavior
Build should fail as it makes no sense for user to annotate the method with
@Funq
if it's going to be ignored.Actual behavior
No warning is logged (that method is ignored), I also didn't find any mention of this in the docs (though it might be obvious that only
public
is expected...). Non-public method annotated with@Funq
is not registered.How to Reproduce?
Reproducer:
Steps to reproduce the behavior:
@Funq
Output of
uname -a
orver
Linux fedora 5.19.4-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Aug 25 17:42:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Output of
java -version
openjdk version "17.0.3" 2022-04-19
GraalVM version (if different from Java)
GraalVM CE 22.1.0
Quarkus version or git rev
999-SNAPSHOT
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.8.6
Additional information
I'll submit the PR for this provided there is an agreement it's a bug. I already have a validation prepared.
The text was updated successfully, but these errors were encountered: