Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Funq over non-public methods are ignored but information is not logged/no ex/nothing in docs #27669

Closed
michalvavrik opened this issue Sep 1, 2022 · 1 comment · Fixed by #27670
Labels
area/funqy kind/bug Something isn't working
Milestone

Comments

@michalvavrik
Copy link
Contributor

Describe the bug

I accidentally defined @Funq function with friendly visibility like this:

@Funq
String hello(Map<String, Integer> map) {
...
}

however non-public methods are ignored (which makes sense) as clz#getMethods here

only return public methods and thus when I called the Funq function I got NOT FOUND.

Expected behavior

Build should fail as it makes no sense for user to annotate the method with @Funq if it's going to be ignored.

Actual behavior

No warning is logged (that method is ignored), I also didn't find any mention of this in the docs (though it might be obvious that only public is expected...). Non-public method annotated with @Funq is not registered.

How to Reproduce?

Reproducer:

Steps to reproduce the behavior:

  1. define non-public method annotated with @Funq
  2. call it

Output of uname -a or ver

Linux fedora 5.19.4-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Aug 25 17:42:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

openjdk version "17.0.3" 2022-04-19

GraalVM version (if different from Java)

GraalVM CE 22.1.0

Quarkus version or git rev

999-SNAPSHOT

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.8.6

Additional information

I'll submit the PR for this provided there is an agreement it's a bug. I already have a validation prepared.

@michalvavrik michalvavrik added the kind/bug Something isn't working label Sep 1, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 1, 2022

/cc @matejvasek, @patriot1burke

michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Sep 1, 2022
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Sep 1, 2022
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Sep 1, 2022
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Sep 4, 2022
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Sep 5, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 8, 2022
evanchooly pushed a commit to nenros/quarkus that referenced this issue Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/funqy kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant