Make sure methods annotated with @Funq are declared as public
#27670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me |
This comment has been minimized.
This comment has been minimized.
michalvavrik
force-pushed
the
feature/funq-validate-methods-are-public
branch
from
c2d06b8
to
582e1ea
Compare
|
one nit: missing test |
|
sure, I'll add the test. |
michalvavrik
force-pushed
the
feature/funq-validate-methods-are-public
branch
from
582e1ea
to
41a61a8
Compare
|
Here you go. |
michalvavrik
force-pushed
the
feature/funq-validate-methods-are-public
branch
from
41a61a8
to
b992535
Compare
|
Rebased onto current main as other PR changed pom.xml. |
This comment has been minimized.
This comment has been minimized.
|
In light of the test failures, are we sure that |
|
Only test that's failing is the one I added on Friday here #27674. It tests exactly what it should, but I keep forgetting to declare methods public. It's my fault, but validation is good thing. I'll fix in a minute. |
michalvavrik
force-pushed
the
feature/funq-validate-methods-are-public
branch
from
b992535
to
51cffe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #27669
Throw an exception and break the build when non-public methods are annotated with
@Funqas only public methods are registered as functions. This will give developer the information he made mistake during the build as there is no good reason to declare methods with@Funqand don't use them as Funq functions.