Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a native image extension #3013

Closed
dmlloyd opened this issue Jun 27, 2019 · 2 comments
Closed

Introduce a native image extension #3013

dmlloyd opened this issue Jun 27, 2019 · 2 comments
Labels
kind/enhancement New feature or request triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@dmlloyd
Copy link
Member

dmlloyd commented Jun 27, 2019

Description
Make native image be an extension rather than a dedicated Mojo. Make sure the extension can be explicitly disabled by a configuration property. Make sure all the current Mojo configuration flags are moved into the build-time configuration of the extension.

Implementation ideas
Produce the native image during the augment phase. Use a virtual build item as a pseudo target for the native image output. The virtual item would be declared as a final item if the extension is present and enabled. Build steps can use weak production to produce code that is conditional on native image being enabled.

@gsmet
Copy link
Member

gsmet commented Nov 13, 2019

@dmlloyd hasn't this been addressed by Stuart's latest work on the subject?

@dmlloyd
Copy link
Member Author

dmlloyd commented Nov 14, 2019

Yes, I think this can be considered solved.

@dmlloyd dmlloyd closed this as completed Nov 14, 2019
@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

No branches or pull requests

2 participants