Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a JNIBuildItem to let extensions enable JNI #2999

Closed
emmanuelbernard opened this issue Jun 27, 2019 · 9 comments · Fixed by #3060
Closed

Offer a JNIBuildItem to let extensions enable JNI #2999

emmanuelbernard opened this issue Jun 27, 2019 · 9 comments · Fixed by #3060
Labels
area/core kind/enhancement New feature or request
Milestone

Comments

@emmanuelbernard
Copy link
Member

emmanuelbernard commented Jun 27, 2019

See https://groups.google.com/d/topic/quarkus-dev/pLwbEB1VCP0/discussion for the conversation

@dmlloyd
Copy link
Member

dmlloyd commented Jun 27, 2019

@Dufgui
Copy link
Contributor

Dufgui commented Jul 1, 2019

quarkusio/quarkus-quickstarts#235
I can continue on it ? Are you ok with my quickstart/integration test case ?

@dmlloyd
Copy link
Member

dmlloyd commented Jul 1, 2019

I think that we're going to want to get the native image extension work underway first (see #3013).

@emmanuelbernard
Copy link
Member Author

emmanuelbernard commented Jul 1, 2019 via email

@dmlloyd
Copy link
Member

dmlloyd commented Jul 1, 2019

Is it? It didn't seem easy to me, but that might be due to my familiarity (or lack thereof) with the current build phase system and the way it integrates with Maven/Gradle.

@emmanuelbernard
Copy link
Member Author

emmanuelbernard commented Jul 1, 2019 via email

@gsmet
Copy link
Member

gsmet commented Jul 1, 2019

Yeah, it's a hack that was present before and I refined for the SSL native support.

Basically, we push properties to the native-image.properties file which is read in NativeImagePhase (see https://github.com/quarkusio/quarkus/blob/master/core/creator/src/main/java/io/quarkus/creator/phase/nativeimage/NativeImagePhase.java#L384 ).

So, while having native image build as an extension is definitely more future proof, we could probably use this machinery temporarily to fix this one (and #3014 while we're at it).

@dmlloyd dmlloyd removed their assignment Jul 1, 2019
Dufgui added a commit to Dufgui/quarkus that referenced this issue Jul 1, 2019
@Dufgui
Copy link
Contributor

Dufgui commented Jul 1, 2019

I do the code just by following what SSL native do. Now I will think about what must really done to work and test it ;o)

@emmanuelbernard
Copy link
Member Author

oops

Dufgui added a commit to Dufgui/quarkus that referenced this issue Jul 6, 2019
Dufgui added a commit to Dufgui/quarkus that referenced this issue Jul 6, 2019
Dufgui added a commit to Dufgui/quarkus that referenced this issue Jul 8, 2019
gsmet pushed a commit to Dufgui/quarkus that referenced this issue Jul 9, 2019
@gsmet gsmet added this to the 0.19.0 milestone Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants