Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random test port does not work together with google-cloud-functions extensions #35476

Closed
rsvoboda opened this issue Aug 22, 2023 · 1 comment · Fixed by #36746
Closed

Random test port does not work together with google-cloud-functions extensions #35476

rsvoboda opened this issue Aug 22, 2023 · 1 comment · Fixed by #36746
Assignees
@loicmathieu
Labels
area/funqy area/google-cloud-functions kind/bug Something isn't working
Milestone
3.6.0

Comments

@rsvoboda
Copy link
Member

Describe the bug

Random test port does not work together with quarkus-google-cloud-functions and quarkus-funqy-google-cloud-functions extensions

Running mvn clean verify -Dquarkus.http.test-port=0 with app that is using google cloud functions extensions.

Similar to #23581 issue for amazon-lambda

Example of errors:

[ERROR] Errors:
[ERROR]   GreetingFunctionsCloudEventsTest.testHelloCloudEvent:15 » IllegalArgument Port must be greater than 0
[ERROR]   GreetingFunctionsPubSubTest.testHelloPubSubWorld:15 » IllegalArgument Port must be greater than 0
[ERROR]   GreetingFunctionsStorageTest.testHelloGCSWorld:15 » IllegalArgument Port must be greater than 0
[INFO]
[ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0

Expected behavior

Running mvn clean verify -Dquarkus.http.test-port=0 passes

Actual behavior

Running mvn clean verify -Dquarkus.http.test-port=0 fails

How to Reproduce?

Output of uname -a or ver

macOS

Output of java -version

Java 17

GraalVM version (if different from Java)

No response

Quarkus version or git rev

3.2.4.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@rsvoboda rsvoboda added the kind/bug Something isn't working label Aug 22, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 22, 2023

/cc @loicmathieu (google-cloud), @matejvasek (funqy), @patriot1burke (funqy)

@loicmathieu loicmathieu self-assigned this Oct 27, 2023
loicmathieu added a commit to loicmathieu/quarkus that referenced this issue Oct 27, 2023
@loicmathieu
Allow using a random test port within Google Cloud Function tests
12e0afc 
Fixes quarkusio#35476
@loicmathieu loicmathieu mentioned this issue Oct 27, 2023
Merged
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Nov 15, 2023
@gsmet gsmet modified the milestones: 3.7 - main, 3.6.0 Nov 17, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue Nov 17, 2023
@loicmathieu @gsmet
Allow using a random test port within Google Cloud Function tests
5362a83 
Fixes quarkusio#35476

(cherry picked from commit 12e0afc)
computerlove pushed a commit to computerlove/quarkus that referenced this issue Nov 27, 2023
@loicmathieu @computerlove
Allow using a random test port within Google Cloud Function tests
ad14b6d 
Fixes quarkusio#35476
DavideD pushed a commit to DavideD/quarkus that referenced this issue Nov 27, 2023
@loicmathieu @DavideD
Allow using a random test port within Google Cloud Function tests
8206472 
Fixes quarkusio#35476
benkard pushed a commit to benkard/mulkcms2 that referenced this issue Dec 2, 2023
Update all non-major dependencies (mulk/mulkcms2!47)
c79ec7d 
This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.222.0` -> `^0.223.0`](https://renovatebot.com/diffs/npm/flow-bin/0.222.0/0.223.2) |
| [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.5.3` -> `3.6.0` |
| [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | minor | `3.5.3` -> `3.6.0` |

---

### Release Notes

<details>
<summary>flowtype/flow-bin</summary>

### [`v0.223.2`](flow/flow-bin@5bb7bcf...6e1e3f7)

[Compare Source](flow/flow-bin@5bb7bcf...6e1e3f7)

### [`v0.223.0`](flow/flow-bin@84a68f1...5bb7bcf)

[Compare Source](flow/flow-bin@84a68f1...5bb7bcf)

</details>

<details>
<summary>quarkusio/quarkus</summary>

### [`v3.6.0`](https://github.com/quarkusio/quarkus/releases/tag/3.6.0)

[Compare Source](quarkusio/quarkus@3.5.3...3.6.0)

##### Major changes

-   [#&#8203;37241](quarkusio/quarkus#37241) - Make improvements to REST Client SSE handling

##### Complete changelog

-   [#&#8203;37242](quarkusio/quarkus#37242) - Support Docker Desktop for building native executables
-   [#&#8203;37241](quarkusio/quarkus#37241) - Make improvements to REST Client SSE handling
-   [#&#8203;37240](quarkusio/quarkus#37240) - Updates Infinispan to 14.0.21.Final
-   [#&#8203;37238](quarkusio/quarkus#37238) - Build cache - Only store if the access key is around
-   [#&#8203;37236](quarkusio/quarkus#37236) - Api to read minimum and recommended Java versions from catalog metadata
-   [#&#8203;37221](quarkusio/quarkus#37221) - Image updates (including Java 21 base image)
-   [#&#8203;37218](quarkusio/quarkus#37218) - Fix OpenTelemetry trace exclusion of endpoints served from the management interface
-   [#&#8203;37213](quarkusio/quarkus#37213) - Add basic Range header support
-   [#&#8203;37205](quarkusio/quarkus#37205) - Resteasy-reactive Partial Content support (Range: bytes http header)
-   [#&#8203;37204](quarkusio/quarkus#37204) - Allow to define allowed roles as configuration expressions inside `@SecureField` annotation
-   [#&#8203;37201](quarkusio/quarkus#37201) - Fixed sample code for KotlinModule initialization
-   [#&#8203;37198](quarkusio/quarkus#37198) - Some minor refinements for build scans
-   [#&#8203;37193](quarkusio/quarkus#37193) - AccessDeniedException error with build using native image on linux with Docker Desktop
-   [#&#8203;37185](quarkusio/quarkus#37185) - Removed DependencyFlags.REMOVED
-   [#&#8203;37170](quarkusio/quarkus#37170) - Fix snapshots following a collision of pull requests
-   [#&#8203;37166](quarkusio/quarkus#37166) - Support custom Authorization schemes for OIDC bearer tokens
-   [#&#8203;37162](quarkusio/quarkus#37162) - Bump org.apache.commons:commons-text from 1.10.0 to 1.11.0
-   [#&#8203;37161](quarkusio/quarkus#37161) - Bump io.quarkus:quarkus-platform-bom-maven-plugin from 0.0.97 to 0.0.99
-   [#&#8203;37158](quarkusio/quarkus#37158) - Bump com.unboundid:unboundid-ldapsdk from 6.0.9 to 6.0.10
-   [#&#8203;37153](quarkusio/quarkus#37153) - Bump smallrye-jwt version to 4.4.0
-   [#&#8203;37149](quarkusio/quarkus#37149) - Bump com.squareup.okio:okio from 1.17.2 to 1.17.6 in /bom/application
-   [#&#8203;37107](quarkusio/quarkus#37107) - Rest client able to get full SSE event
-   [#&#8203;37101](quarkusio/quarkus#37101) - Remove `smallrye-opentracing` from native tests modules in CI
-   [#&#8203;37094](quarkusio/quarkus#37094) - Bump jakarta.json:jakarta.json-api from 2.1.2 to 2.1.3
-   [#&#8203;37092](quarkusio/quarkus#37092) - Bump mongo-client.version from 4.11.0 to 4.11.1
-   [#&#8203;37067](quarkusio/quarkus#37067) - SmallRye GraphQL 2.6 + custom scalar registration
-   [#&#8203;37053](quarkusio/quarkus#37053) - Clarify dynamic Environment Variables name conversion
-   [#&#8203;37004](quarkusio/quarkus#37004) - Move failsafe config to the root instead of in an execution
-   [#&#8203;36976](quarkusio/quarkus#36976) - Error in JBossLoggerFinder during integration test
-   [#&#8203;36804](quarkusio/quarkus#36804) - `@SecureField` add expression support
-   [#&#8203;36801](quarkusio/quarkus#36801) - Add note that endpointdisabled does not work native
-   [#&#8203;36746](quarkusio/quarkus#36746) - Allow using a random test port within Google Cloud Function tests
-   [#&#8203;35476](quarkusio/quarkus#35476) - Random test port does not work together with google-cloud-functions extensions

</details>

<details>
<summary>quarkusio/quarkus-platform</summary>

### [`v3.6.0`](quarkusio/quarkus-platform@3.5.3...3.6.0)

[Compare Source](quarkusio/quarkus-platform@3.5.3...3.6.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
@rsvoboda rsvoboda mentioned this issue Dec 7, 2023
Merged
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Feb 8, 2024
@loicmathieu @holly-cummins
Allow using a random test port within Google Cloud Function tests
30192c9 
Fixes quarkusio#35476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loicmathieu loicmathieu

Labels
area/funqy area/google-cloud-functions kind/bug Something isn't working
Projects
None yet
Milestone
3.6.0
Development

Successfully merging a pull request may close this issue.

Allow using a random test port within Google Cloud Function tests loicmathieu/quarkus
3 participants
@rsvoboda @gsmet @loicmathieu