Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI wraps code viewer content in <!----> HTML comments (on Safari and Chrome, but not Firefox) #38309

Closed
holly-cummins opened this issue Jan 19, 2024 · 1 comment · Fixed by #38848
Assignees
Labels
area/dev-ui kind/bug Something isn't working
Milestone

Comments

@holly-cummins
Copy link
Contributor

Describe the bug

This was actually spotted by @hannotify, I'm just passing on his diagnosis. :)

See attached screenshot. Content using the code viewer seems to get some unwanted HTML comments appended to either side.

image

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

I couldn't reproduce on Firefox, only on Safari and Chrome.

Running an application with a non-empty application.properties file and looking in the source editor in the Configuration view should do it: http://localhost:8080/q/dev-ui/configuration-source-editor

Alternatively, for a more exciting reproducer, you could build https://github.com/holly-cummins/bon-jova-rockstar-implementation and then quarkus dev in the bon-jova-app project. Then click on the Rockstar endpoints item in the Bon Jova tile and expand one of the rows. That will give the following:

image

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-ui kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants