Use new code block component for Dev UI Code displays #38848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
|
@hannotify f.y.i |
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
phillip-kruger
force-pushed
the
dev-ui-code-block
branch
from
9ec5b7e
to
87e0d25
Compare
Status for workflow
|
|
🙈 The PR is closed and the preview is expired. |
cescoffier
approved these changes
Feb 19, 2024
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use a new component to display (and edit) code / markup in Dev UI.
<!---->HTML comments (on Safari and Chrome, but not Firefox) #38309Now based on codemirror 6 that seems to fix the chrome issue.