Add property to force cache-control: no-store on: quarkus.smallrye-health
#39868
Labels
Milestone
Comments
|
/cc @Ladicek (smallrye), @gwenneg (cache), @jmartisk (health,smallrye), @phillip-kruger (smallrye), @radcortez (smallrye), @xstefank (health) |
|
Yeah I think that makes perfect sense and we should avoid all caching for health checks. |
|
This definitely makes sense but I would argue that we should do this OOTB. |
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Apr 4, 2024
|
#39872 is what I have in mind |
gsmet
added a commit
that referenced
this issue
Apr 4, 2024
Use cache-control header to make sure health checks aren't cached
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Apr 9, 2024
Fixes: quarkusio#39868 (cherry picked from commit 6f53e36)
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Apr 9, 2024
Fixes: quarkusio#39868 (cherry picked from commit 6f53e36)
ketola
pushed a commit
to ketola/quarkus
that referenced
this issue
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Between our browser and target server, we use corporate proxy.
When our UI check URL health of our application modules, when one module is down (TCP connexion down : Couldn't connect to server), our proxy continue to serve a cached response.
If the response to the healthcheck URL included a
cache-control: no-storeheader, it would not be stored in our corporate proxy's cache.Implementation ideas
Add a property (eg:
quarkus.smallrye-health.reponse-header."cache-control"=no-store) to customize HTTP response headerThe text was updated successfully, but these errors were encountered: