Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache-control header to make sure health checks aren't cached #39872

Merged
merged 1 commit into from Apr 4, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 4, 2024

@jycr
Copy link
Contributor

jycr commented Apr 4, 2024

Ok for me!

@geoand geoand requested a review from cescoffier April 4, 2024 08:04
@geoand geoand marked this pull request as ready for review April 4, 2024 08:04
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6f53e36.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@gsmet gsmet merged commit 876ed46 into quarkusio:main Apr 4, 2024
57 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Apr 4, 2024
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 4, 2024
@geoand geoand deleted the #39868 branch April 4, 2024 14:15
@xstefank
Copy link
Contributor

xstefank commented Apr 5, 2024

@geoand shouldn't this be configurable? Is it desirable in every Quarkus app?

@geoand
Copy link
Contributor Author

geoand commented Apr 5, 2024

I personally can't think of why it would need to configurable, but I am totally open to hearing arguments advocating otherwise

@gsmet gsmet modified the milestones: 3.10 - main, 3.9.3 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add property to force cache-control: no-store on: quarkus.smallrye-health
4 participants