Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension metadata to all the extensions #833

Closed
gsmet opened this issue Feb 11, 2019 · 7 comments · Fixed by #4423
Closed

Add extension metadata to all the extensions #833

gsmet opened this issue Feb 11, 2019 · 7 comments · Fixed by #4423
Assignees
Labels
area/platform Issues related to definition and interaction with Quarkus Platform
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Feb 11, 2019

Following the integration of https://github.com/jbossas/protean-shamrock/pull/663/files#diff-2cfc93ecb828363d0be95549c3abbbfeR31 , we need to add the appropriate metadata to all the existing extensions.

See our extensions.json for some label ideas.

@gsmet gsmet self-assigned this Feb 11, 2019
@gsmet
Copy link
Member Author

gsmet commented Feb 11, 2019

Check #832 as a follow-up of this one.

@dmlloyd
Copy link
Member

dmlloyd commented Feb 11, 2019

We should be thinking of a way to unify this information with the descriptor that we must add for the Curate phase. There's no reason to have two different descriptors which do approximately the same thing.

@kenfinnigan
Copy link
Member

If the curate phase uses the Extension class then it can become the metadata for an extension across everything

@dmlloyd
Copy link
Member

dmlloyd commented Feb 11, 2019

The curate phase is happening during the bootstrap stub, so we probably can't/shouldn't bring in a JSON parser. What about using a properties format instead?

@gsmet
Copy link
Member Author

gsmet commented Feb 11, 2019

So there are 2 different things:

  • the actual metadata are properties in the pom file of the extension (see link above)
  • then a JSON file is created for consumption by others (Web UI...)

@gsmet
Copy link
Member Author

gsmet commented Feb 21, 2019

I think we can live with it for now. Removing the first-public-release tag: we can do that later, the current JSON file works well enough.

@maxandersen maxandersen added the area/platform Issues related to definition and interaction with Quarkus Platform label Oct 2, 2019
@maxandersen
Copy link
Member

Since GA is now getting closer we should do this.

  • add the labels, cateogories, etc. to the quarkus-extension.properties
  • extension.json should then be generated from this file.

@aloubyansky aloubyansky added this to the 0.25.0 milestone Oct 3, 2019
@paulrobinson paulrobinson mentioned this issue Oct 15, 2019
18 tasks
maxandersen pushed a commit to maxandersen/quarkus that referenced this issue Nov 5, 2022
* feat: `info tools` now returns a lot more information

Fixes quarkusio#833

* fix: Make sure we don't get stuck in endless loops

For quarkusio#833

* chore: disable HTML escaping for the `info tools` output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants