Add support for mutiny types in reactive routes #10379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
reviewed
Jul 1, 2020
mkouba
reviewed
Jul 1, 2020
| @@ -496,25 +473,74 @@ void implementInvoke(BeanInfo bean, MethodInfo method, ClassCreator invokerCreat | |||
|
|
|||
| ResultHandle paramHandle; | |||
| MethodDescriptor methodDescriptor; | |||
| String returnType = descriptor.getReturnType().name().toString(); | |||
|
|
|||
| // TODO Make Routing Context optional, allow injected Response and Request individually. | |||
There was a problem hiding this comment.
+1 if a method returns something we should make the context param optional...
mkouba
requested changes
Jul 1, 2020
There was a problem hiding this comment.
LGTM.
Except for the inconsistency when returning Multi<String> as described here: #10379 (comment). I don't see a good reason for this behavior.
However, if there are any strong arguments feel free to dismiss my review...
mkouba
approved these changes
Jul 3, 2020
|
JDK 14 failure is unrelated. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Uni, Multi, and SSE to reactive routes.