Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename prepare goal to generate-code #11624

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Rename prepare goal to generate-code #11624

merged 2 commits into from
Aug 26, 2020

Conversation

michalszynkiewicz
Copy link
Member

No description provided.

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/maven labels Aug 25, 2020
@michalszynkiewicz
Copy link
Member Author

CC @stuartwdouglas @rsvoboda

rsvoboda
rsvoboda requested changes Aug 26, 2020
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes were requested and I have two additional questions

  • Why are there separate goals generate-code and generate-code-tests goals?
  • Why isn't generate-code-tests goal explained in grpc-getting-started.adoc?

docs/src/main/asciidoc/grpc-getting-started.adoc Show resolved Hide resolved
docs/src/main/asciidoc/grpc-getting-started.adoc Show resolved Hide resolved
@michalszynkiewicz michalszynkiewicz merged commit 5955348 into quarkusio:master Aug 26, 2020
@gsmet gsmet mentioned this pull request Aug 27, 2020
Closed
@gsmet gsmet added this to the 1.7.2.Final milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/maven
Projects
None yet
Milestone
1.7.2.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@michalszynkiewicz @rsvoboda @gsmet