Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that @TestProfile works properly with random http port #11741

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Ensure that @TestProfile works properly with random http port #11741

merged 1 commit into from
Aug 31, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 31, 2020

Fixes: #11688

@geoand geoand added this to the 1.7.2.Final milestone Aug 31, 2020
@geoand
Copy link
Contributor Author

geoand commented Aug 31, 2020

Normally Stuart would review this, but since he is on PTO can I get a review from @gastaldi or @gsmet ?

@geoand geoand changed the title Ensure that @TestProfile works properly with random port Ensure that @TestProfile works properly with random http port Aug 31, 2020
@geoand geoand removed this from the 1.7.2.Final milestone Aug 31, 2020
@geoand geoand requested a review from gastaldi August 31, 2020 12:18
gastaldi
gastaldi approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit 3716442 into quarkusio:master Aug 31, 2020
@geoand geoand deleted the #11688 branch August 31, 2020 14:32
@gsmet gsmet added this to the 1.7.2.Final milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/resteasy-classic area/testing
Projects
None yet
Milestone
1.7.2.Final
Development

Successfully merging this pull request may close these issues.

@TestProfile and @TestHTTPResource don't play well with quarkus.http.test-port=0
3 participants
@geoand @gastaldi @gsmet