Rename ContextAwareTokenCredential to OidcTokenCredential and move it out of the runtime package #11789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've checked if injecting |
… out of the runtime package
sberyozkin
force-pushed
the
sec_augmentor_token_cred_improvements
branch
from
07e45fe
to
fbe75f1
Compare
pedroigor
approved these changes
Sep 8, 2020
|
@pedroigor thanks, will wait for the builds to finish |
sberyozkin
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10907.
There have been a few queries to do with accessing
RoutingContextin the customSecurityIdentityAugmentor.Pedro @pedroigor has already provided a useful
ContextAwareTokenCredentialfor the internal (runtime) OIDC purposes.So I've only moved this class to out of the runtime package to make it part of the API, and also renamed it to
OidcTokenCredential(we may add more properties into it which will be common to both OIDC ID and AccessToken credentials) and renamedgetContexttogetRoutIngContextand made it public.Stuart, Pedro's original solution looks simple enough for me at the moment and should work, but you may have a better idea how to pass the routing context around, have a look please :-)