Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled k8s client test #11809

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 2, 2020

This is done because as @jaikiran figured out, the test resource
of the prod mode test can leak into the regular @QuarkusTest.

Follow up of: #11799

This is done because as @jaikiran figured out, the test resource
of the prod mode test can leak into the regular @QuarkusTest
@jaikiran
Copy link
Member

jaikiran commented Sep 2, 2020

@geoand, you forgot the @BeforeAll change to this KubernetesClientTest :)

@geoand
Copy link
Contributor Author

geoand commented Sep 2, 2020

BeforeAll

OMG, I'll never learn :)

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 2, 2020
@geoand geoand changed the title Use a different surefire runner for prod mode k8s client tests Fix k8s client test Sep 2, 2020
@geoand geoand changed the title Fix k8s client test Fix disabled k8s client test Sep 2, 2020
@geoand geoand merged commit cabdee4 into quarkusio:master Sep 2, 2020
@geoand geoand deleted the k8s-client-test-fix branch September 2, 2020 14:49
@gsmet gsmet added this to the 1.7.2.Final milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants