Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kotlin integration in the Gradle plugin #11873

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Fix Kotlin integration in the Gradle plugin #11873

merged 1 commit into from
Sep 4, 2020

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Sep 4, 2020

Fixes #11867

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Sep 4, 2020
@gastaldi gastaldi force-pushed the gradle_fix branch 2 times, most recently from ed5fe0c to 56bca87 Compare September 4, 2020 00:44
glefloch
glefloch approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

devtools/gradle/src/main/java/io/quarkus/gradle/QuarkusPlugin.java Show resolved Hide resolved
@gsmet
Copy link
Member

gsmet commented Sep 4, 2020

If this is a regression, I think we need a test. Don't know how hard it will be to add one though.

@gastaldi
Copy link
Contributor Author

gastaldi commented Sep 4, 2020

@gsmet yeah, sorry. I updated my PR with an integration test.

Can we "re-release" the 1.7.2.Final Gradle plugin in the plugin portal with this fix?

@gastaldi gastaldi added this to the 1.9.0 - master milestone Sep 4, 2020
@gastaldi gastaldi merged commit 9f62d0d into quarkusio:master Sep 4, 2020
@gastaldi gastaldi deleted the gradle_fix branch September 4, 2020 16:03
@gsmet gsmet modified the milestones: 1.9.0 - master, 1.8.0.Final Sep 4, 2020
@gsmet gsmet modified the milestones: 1.8.0.Final, 1.7.3.Final Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

@glefloch glefloch glefloch approved these changes

@michalszynkiewicz michalszynkiewicz Awaiting requested review from michalszynkiewicz

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Milestone
1.7.3.Final
Development

Successfully merging this pull request may close these issues.

Gradle build fails after upgrade to 1.7.2
4 participants
@gastaldi @gsmet @aloubyansky @glefloch