Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new property to configure "hibernate.format_sql" in the application.properties #12206

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Adds new property to configure "hibernate.format_sql" in the application.properties #12206

merged 1 commit into from
Oct 1, 2020

Conversation

dfbadawi
Copy link
Contributor

@dfbadawi dfbadawi commented Sep 19, 2020 •
edited
Loading

quarkus.hibernate-orm.log.format-sql=false

This allows to configure hibernate's hibernate.format_sql property in the application.properties.

Fixes: #12204

gsmet
gsmet requested changes Sep 19, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added some suggestions.

...ent/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfigPersistenceUnit.java Outdated Show resolved Hide resolved
...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java Outdated Show resolved Hide resolved
extensions/hibernate-orm/deployment/src/test/resources/application-log-sql-formatted.properties Outdated Show resolved Hide resolved
...yment/src/main/java/io/quarkus/hibernate/reactive/deployment/HibernateReactiveProcessor.java Outdated Show resolved Hide resolved
...ent/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfigPersistenceUnit.java Show resolved Hide resolved
@dfbadawi
Copy link
Contributor Author

@gsmet suggestions applied :)

@dfbadawi dfbadawi requested a review from gsmet September 19, 2020 10:32
@dfbadawi dfbadawi mentioned this pull request Sep 22, 2020
Closed
gsmet
gsmet approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I squashed everything and will wait for CI to merge.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 30, 2020
@gsmet gsmet added this to the 1.9.0 - master milestone Sep 30, 2020
@gsmet gsmet merged commit 2ba1dc6 into quarkusio:master Oct 1, 2020
@gsmet
Copy link
Member

gsmet commented Oct 1, 2020

Merged, thanks!

@Sanne
Copy link
Member

Sanne commented Oct 1, 2020

thanks!

@dfbadawi dfbadawi deleted the feature/12204-format-sql-property branch October 2, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.9.0.CR1
Development

Successfully merging this pull request may close these issues.

Allow configuration of Hibernate to disable "format_sql" property
3 participants
@dfbadawi @gsmet @Sanne