Introduce BansRuntimeDependency for extensions/* #12220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #11174 - refactor RequiresMinimalDeploymentDependency for common base class - extend invoker smoketest (now with 3 executions) - disable invoker tests for -Dquickly - activate new rule for all extensions in extensions-parent - change parent of all extensions from build-parent to extensions-parent - fix found rule violations
|
Very very cool! |
|
One issue I see is that once we merge this, we will need to alert the community as their extensions could potentially break |
|
@geoand I am missing some details about that. |
|
I guess I am the one that spoke too soon 😂. I thought that this contained a change in Quarkus bootstrap that would cause a failure is the extension was not properly configured. |
|
@geoand no problem! |
aloubyansky
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11174 (and should prevent such tedious tasks as #12205)
/cc @gsmet @aloubyansky @gastaldi