Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check naming strategy in Spring Boot properties #12547

Merged

Conversation

gytis
Copy link

@gytis gytis commented Oct 6, 2020

Fixes #12483

@famod famod added the area/spring Issues relating to the Spring integration label Oct 6, 2020
@geoand
Copy link
Contributor

geoand commented Oct 6, 2020

@gytis CI seems to not like it :)

@geoand
Copy link
Contributor

geoand commented Oct 6, 2020

Also, this is breaking change so we will need to have something in the wiki

@gytis gytis force-pushed the use-naming-strategy-in-spring-properties branch from d8c204a to 02d78ae Compare October 6, 2020 15:30
@gytis
Copy link
Author

gytis commented Oct 6, 2020

@geoand when and where do you want me to write an entry about the breaking change?

@geoand
Copy link
Contributor

geoand commented Oct 6, 2020

Just a note here and I'll copy it into the wiki.

@gytis
Copy link
Author

gytis commented Oct 6, 2020

This change replaces a hardcoded verbatim naming strategy of Spring Boot properties extension with the one defined in quarkus.arc.config-properties-default-naming-strategy property (kebab by default).

To keep your application operating as before, perform one of the following changes:

  • Set quarkus.arc.config-properties-default-naming-strategy=verbatim in the application.(yml|properties)
  • Replace the properties from verbatim style to kebab (default) or the one defined in quarkus.arc.config-properties-default-naming-strategy property.

@geoand
Copy link
Contributor

geoand commented Oct 7, 2020

The CI failure is completely unrelated ( quarkus-smallrye-graphql-deployment)

@geoand geoand added this to the 1.9.0 - master milestone Oct 7, 2020
@geoand geoand merged commit cd50f5b into quarkusio:master Oct 7, 2020
@gsmet gsmet changed the title Check naming strategy in Spring Boot properties #12483 Check naming strategy in Spring Boot properties Oct 7, 2020
@gytis gytis deleted the use-naming-strategy-in-spring-properties branch February 17, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/spring Issues relating to the Spring integration release/breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring @ConfigProperties bindings are not relaxed
3 participants