Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace useless DynamicFeatureResourceInfo class with ResteasyReactiveResourceInfo #13983

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Replace useless DynamicFeatureResourceInfo class with ResteasyReactiveResourceInfo #13983

merged 1 commit into from
Dec 21, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 19, 2020

Fixes: #13981

@gsmet
Copy link
Member

gsmet commented Dec 21, 2020

Hmmm. Shouldn't we add a test?

@geoand
Copy link
Contributor Author

geoand commented Dec 21, 2020

No need, the class which is now used gets exercised in a lot of existing tests

gsmet
gsmet approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion with @geoand , let's get this in to unblock a very common use case.

@gsmet gsmet merged commit 796af8e into quarkusio:master Dec 21, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 21, 2020
@geoand geoand deleted the #13981 branch December 21, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0.Beta2
Development

Successfully merging this pull request may close these issues.

RESTEasy Reactive - deploy failure when using opentracing
2 participants
@geoand @gsmet