Bump flyway-core from 7.3.1 to 7.3.2

[dependabot]

Bumps flyway-core from 7.3.1 to 7.3.2.

Release notes

Sourced from flyway-core's releases.

Flyway 7.3.2

See https://flywaydb.org/documentation/learnmore/releaseNotes#7.3.2

Commits

• 76472f1 Include classpath var in bash script
• 18addff Fix #3031: correct undoable value when using info filter
• 0e1956d rename DLL
• 5e00e01 only validate cherry-picked migrations
• 82102c8 Fix #3025: check that attached keywords are on the same line
• 47485ce new callback after each operation
• f53f4d4 Make factory methods static
• f0b8b03 fix bug with execution time in migrate result
• 631cd76 Fix #3024: improve performance of shouldExecute
• c12d281 Fix #3021: Don't cascade when dropping views
• See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[gsmet]

Hmmm, the clean at start test is failing:

Error:  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.256 s <<< FAILURE! - in io.quarkus.flyway.test.FlywayExtensionCleanAtStartTest
Error:  io.quarkus.flyway.test.FlywayExtensionCleanAtStartTest.testFlywayConfigInjection  Time elapsed: 0.205 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: fake_existing_tbl should not exist
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
	at org.junit.jupiter.api.Assertions.fail(Assertions.java:117)
	at io.quarkus.flyway.test.FlywayExtensionCleanAtStartTest.testFlywayConfigInjection(FlywayExtensionCleanAtStartTest.java:45)

@cristhiank any chance you could have a look?

[cristhiank]

Hey @gsmet . Yes, I will take a look to this issue. Wait for the PR by the end of the day ( timezone at 🇨🇴 )

[gsmet]

Closing this one as it will need some work.

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

[cristhiank]

Hi @gsmet, I found a bigger issue while working on this.
The root cause of the error is because the new Flyway version is opening more than one connection when it runs its migration process... This causes that the RUNSCRIPT for H2 is run twice and the database is always pre-populated.

https://github.com/cristhiank/quarkus/blob/2d9abe183157ba60551f057a4d096833fcd31aa0/extensions/flyway/deployment/src/test/resources/clean-and-migrate-at-start-config.properties#L4

The solution I propose is to find a way to run the init sql script at start only once.
I have done some work here:

cristhiank@1621d18

I wasn't able to get the datasource config in the H2TestResource because it is called before Quarkus is initialized so I added some initArgs:
https://github.com/cristhiank/quarkus/blob/1621d186e8cea611b1561d91b6da1b42e31d440e/extensions/flyway/deployment/src/test/java/io/quarkus/flyway/test/FlywayTestResources.java

I just wanted to give a quick update on this, it is still work in progress. I will send the PR soon, I still have to fix one test.

[cristhiank]

This is the conflicting line just FYI:

https://github.com/flyway/flyway/blob/23109376523a3d99620f1a666491a3587121cddb/flyway-core/src/main/java/org/flywaydb/core/internal/database/base/Database.java#L334-L343