Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build order problem #14042

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Fix build order problem #14042

merged 1 commit into from
Dec 24, 2020

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@ghost ghost added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Dec 23, 2020
@famod
Copy link
Member

famod commented Dec 24, 2020

In #13218 I also had to add such a dependency to the cli module but I went for quarkus-arc-deployment since I was getting ArC related errors.
I'm wondering whether we both try to fix the same problem (but with different dependencies).

@stuartwdouglas
Copy link
Member Author

This one is the correct one, as there is a dependency on quarkus-picocli. Adding the quarkus-picocli-deployment module will add a transitive dependency on arc-deployment.

@famod
Copy link
Member

famod commented Dec 24, 2020

So we are both addressing the same problem.
Ok, then I'll update #13218 once your PR is merged.
PS: My PR includes some more build order fixes but is stuck in review.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 24, 2020
@gsmet gsmet merged commit 60a59e4 into quarkusio:master Dec 24, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 24, 2020
@famod famod mentioned this pull request Dec 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.11.0.Beta2
Development

Successfully merging this pull request may close these issues.
4 participants
@stuartwdouglas @famod @geoand @gsmet