Introduce JSON by default support RESTEasy Reactive #14167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
geoand
commented
Jan 7, 2021
Comment on lines
-63
to
-67
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-resteasy-reactive-jsonb-deployment</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
This was never needed in the first place
geoand
commented
Jan 7, 2021
| @@ -21,7 +21,6 @@ | |||
|
|
|||
| @GET | |||
| @Path("/person") | |||
| @Produces(MediaType.APPLICATION_JSON) | |||
There was a problem hiding this comment.
The PR doesn't introduce any new tests, it just reuses the existing ones and removes @Produces(MediaType.APPLICATION_JSON) to ensure everything works properly
geoand
force-pushed
the
rr-json-default
branch
from
7ba5ac5
to
e0f22a2
Compare
|
I have also already updated the testsuite to use the new property |
geoand
force-pushed
the
rr-json-default
branch
from
e0f22a2
to
23aae2d
Compare
geoand
commented
Jan 7, 2021
| return applyAdditionalDefaults(nonAsyncReturnType); | ||
| } | ||
|
|
||
| protected String[] applyAdditionalDefaults(Type nonAsyncReturnType) { |
There was a problem hiding this comment.
Done like this because I only wanted to touch default for the server endpoints
This is done when the jsonb or jackson extensions are used and only applies to application classes and the most common collection classes
geoand
force-pushed
the
rr-json-default
branch
from
23aae2d
to
ba32921
Compare
FroMage
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done when the JSON-B or Jackson extensions are used
and only applies to application classes and the most common
collection classes.
This is probably more complex than absolutely necessary, but it introduces a general way
to determine default produces Media Types.