Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SwaggerUiBuildITem public #14200

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Make SwaggerUiBuildITem public #14200

merged 1 commit into from
Jan 9, 2021

Conversation

oscarfh
Copy link
Contributor

@oscarfh oscarfh commented Jan 8, 2021

I am creating a Dev Console tile for my extension. There I want to link: the extension's ui, the openapi specification (as a file), and the swagger ui "description" for my openapi specification.
Unfortunately the SwaggerUiBuildItem class is package-private, all the other classes in this package are public. So it seems to be OK that this class is also public (specially because BuildItems are though to be something people can listen on and this class is immutable).

I need information generated by this build item (more concrete, the swagger ui final destination) so I can reference
the final destion of my swagger api in my dev console card. All other classes in this package are public and the
fields in this class are also public, therefore it seems safe to make the whole class public
@ghost ghost added the area/swagger-ui label Jan 8, 2021
@gsmet gsmet merged commit 18ae9b9 into quarkusio:master Jan 9, 2021
@ghost ghost added this to the 1.12 - master milestone Jan 9, 2021
@gsmet gsmet modified the milestones: 1.12 - master, 1.11.0.Final Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants