Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV UI: Quick fix for restart issue #15098

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

saumya1singh
Copy link
Contributor

Hey @FroMage!
Here is the PR for that restart issue :)

@saumya1singh saumya1singh changed the title DEV UI: Quick fix in restart issue DEV UI: Quick fix for restart issue Feb 16, 2021
gsmet
gsmet previously requested changes Feb 16, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please squash the 2 commits? Thanks!

@saumya1singh
Copy link
Contributor Author

Could you please squash the 2 commits? Thanks!

Sure sure :)

DEV UI: Fixing restart issue

calling visitStart()
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@FroMage
Copy link
Member

FroMage commented Feb 16, 2021

Well spotted!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 16, 2021
@gsmet gsmet dismissed their stale review February 16, 2021 15:11

Squashed.

@gsmet gsmet merged commit bbdcb3f into quarkusio:master Feb 16, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 16, 2021
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.0.Final Feb 16, 2021
@famod famod removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants