Add quarkus.servlet.max-parameters setting #15216
Conversation
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look? title should not end up with dot
|
quarkus-bot
bot
added
area/dependencies
benkard
changed the title
|
(The CI pipeline is expected to fail until quarkus-http 3.1.0.Beta2 is released.) |
machi1990
requested review from
stuartwdouglas and
gsmet
and removed request for
stuartwdouglas
extensions/undertow/runtime/src/main/java/io/quarkus/undertow/runtime/ServletRuntimeConfig.java
Outdated
Show resolved
Hide resolved
...s/undertow/runtime/src/main/java/io/quarkus/undertow/runtime/UndertowDeploymentRecorder.java
Outdated
Show resolved
Hide resolved
|
A thought: Should the option be under a separate |
There was a problem hiding this comment.
This will need a squash before merging. Thanks!
I'll let @stuartwdouglas approve.
benkard
force-pushed
the
feature/undertow-options
branch
from
01398c8
to
9c38810
Compare
Done. |
|
@gsmet I think your change request is still blocking the merge. Could you have a look, please? Thanks! |
This configures the MAX_PARAMETERS setting in Undertow, which defaults to 1,000. Makes use of the UndertowOptionsMap setter introduced in quarkus-http commit 00223f28f17a246a3075b3f1ce38dc289976a641 and therefore depends on quarkus-http 3.1.0.Beta2. Fixes quarkusio/quarkus-http#63.
We have a default value so we should use an int.
gsmet
force-pushed
the
feature/undertow-options
branch
from
9c38810
to
91d6af9
Compare
|
I rebased and pushed a small additional commit to remove the use of Optional as we have a default value. Let's wait for CI and merge! |
gsmet
added
the
triage/waiting-for-ci
|
Merged, thanks! |
This configures the MAX_PARAMETERS setting in Undertow, which defaults
to 1,000.
Makes use of the UndertowOptionsMap setter introduced in quarkus-http
commit 00223f28f17a246a3075b3f1ce38dc289976a641 and therefore depends on
quarkus-http 3.1.0.Beta2.
Fixes quarkusio/quarkus-http#63.