Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set MAX_PARAMETERS in Undertow #63

Closed
benkard opened this issue Feb 17, 2021 · 3 comments · Fixed by quarkusio/quarkus#15216
Closed

Ability to set MAX_PARAMETERS in Undertow #63

benkard opened this issue Feb 17, 2021 · 3 comments · Fixed by quarkusio/quarkus#15216

Comments

@benkard
Copy link

benkard commented Feb 17, 2021

When using Undertow, a request with more than 1,000 parameters triggers a io.undertow.util.ParameterLimitException. While that's a reasonable default, I have a need to configure it. (A JSF application I am porting to Quarkus via the MyFaces Quarkus extension generates very large requests.)

Undertow provides a way of providing it with an UndertowOptionMap, one key of which is MAX_PARAMETERS. It would be nice if there were a way of setting it through application.properties.
@stuartwdouglas
Copy link
Member

00223f2

Once this is released it will need some code to wire it up in Quarkus

@benkard
Copy link
Author

benkard commented Feb 20, 2021

Wow, that was super fast. Thank you!

benkard added a commit to benkard/quarkus that referenced this issue Feb 20, 2021
@benkard
Add quarkus.http.max-parameters setting.
12dde7d 
This configures the MAX_PARAMETERS setting in Undertow, which defaults
to 1,000.

Makes use of the UndertowOptionsMap setter introduced in quarkus-http
commit 00223f28f17a246a3075b3f1ce38dc289976a641 and therefore depends on
quarkus-http 3.1.0.Beta2.

Fixes quarkusio/quarkus-http#63.
@benkard
Copy link
Author

benkard commented Feb 20, 2021 •
edited
Loading

Here's a start on the Quarkus side: benkard/quarkus@12dde7d

Still need to add a test or two before I open a PR.

@benkard benkard mentioned this issue Feb 20, 2021
Merged
benkard added a commit to benkard/quarkus that referenced this issue Feb 24, 2021
@benkard
Add quarkus.servlet.max-parameters setting.
9c38810 
This configures the MAX_PARAMETERS setting in Undertow, which defaults
to 1,000.

Makes use of the UndertowOptionsMap setter introduced in quarkus-http
commit 00223f28f17a246a3075b3f1ce38dc289976a641 and therefore depends on
quarkus-http 3.1.0.Beta2.

Fixes quarkusio/quarkus-http#63.
gsmet pushed a commit to benkard/quarkus that referenced this issue Mar 16, 2021
@benkard @gsmet
Add quarkus.servlet.max-parameters setting.
49d2690 
This configures the MAX_PARAMETERS setting in Undertow, which defaults
to 1,000.

Makes use of the UndertowOptionsMap setter introduced in quarkus-http
commit 00223f28f17a246a3075b3f1ce38dc289976a641 and therefore depends on
quarkus-http 3.1.0.Beta2.

Fixes quarkusio/quarkus-http#63.
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Add quarkus.servlet.max-parameters setting.
1a9a90d 
    This configures the MAX_PARAMETERS setting in Undertow, which defaults
    to 1,000.

    Makes use of the UndertowOptionsMap setter introduced in quarkus-http
    commit 00223f28f17a246a3075b3f1ce38dc289976a641 and therefore depends on
    quarkus-http 3.1.0.Beta2.

    Fixes quarkusio/quarkus-http#63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add quarkus.servlet.max-parameters setting benkard/quarkus
2 participants
@benkard @stuartwdouglas