Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dokka execution to a profile #16842

Merged
merged 4 commits into from
May 24, 2021
Merged

Move dokka execution to a profile #16842

merged 4 commits into from
May 24, 2021

Conversation

evanchooly
Copy link
Member

Move the dokka executions to a profile to isolate the generation to the release execution. This also converts what little java exists in those repositories to kotlin because apparently dokka chokes on mixed-source modules.

@evanchooly evanchooly requested a review from gsmet April 27, 2021 15:35
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/panache labels Apr 27, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 27, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 7a1247a

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build ⚠️ Check → Logs Raw logs
Attach pull request number ⚠️ Check → Logs Raw logs
CI Sanity Check ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
Native Tests - Read JSON matrix ⚠️ Check → Logs Raw logs
🚫 Native Tests - Windows - ${{ matrix.category }}

@gsmet gsmet changed the title Move dokka execution to a profile. Move dokka execution to a profile Apr 27, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 27, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 3f5c0bf

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/panache/hibernate-orm-panache-kotlin/deployment

io.quarkus.hibernate.orm.panache.kotlin.deployment.test.multiple_pu.MultiplePersistenceUnitConfigTest.panacheOperations - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/panache/hibernate-orm-panache-kotlin/deployment

io.quarkus.hibernate.orm.panache.kotlin.deployment.test.multiple_pu.MultiplePersistenceUnitConfigTest.panacheOperations - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 extensions/panache/hibernate-orm-panache-kotlin/deployment

io.quarkus.hibernate.orm.panache.kotlin.deployment.test.multiple_pu.MultiplePersistenceUnitConfigTest.panacheOperations - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 29, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 3f5c0bf

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/panache/hibernate-orm-panache-kotlin/deployment

io.quarkus.hibernate.orm.panache.kotlin.deployment.test.multiple_pu.MultiplePersistenceUnitConfigTest.panacheOperations - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/panache/hibernate-orm-panache-kotlin/deployment

io.quarkus.hibernate.orm.panache.kotlin.deployment.test.multiple_pu.MultiplePersistenceUnitConfigTest.panacheOperations - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 extensions/panache/hibernate-orm-panache-kotlin/deployment

io.quarkus.hibernate.orm.panache.kotlin.deployment.test.multiple_pu.MultiplePersistenceUnitConfigTest.panacheOperations - More details - Source on GitHub

gsmet
gsmet previously requested changes May 8, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revisit this PR with the addition of #17009 ?

Also I added a question.

@gsmet
Copy link
Member

gsmet commented May 8, 2021

@evanchooly I think we should limit this PR to its original purpose. The other changes look unrelated?

@evanchooly
Copy link
Member Author

Well, it gets tricky here. Dokka apparently doesn't work well with mixed source trees. So I thought "ill just move it all to kotlin!" Which lead to a while.host of interesting issues like missing tests compared to the Java side, etc. I van move off resolving this diffs to a different PR but there are still failures in tests to resolve.

It's definitely snowballing so I might just rebranch and apply lessons learned and side step these other elements as much as I can. But it feels a bit like pulling on that one loose thread and watching the whole sweater unravel.

@gsmet
Copy link
Member

gsmet commented May 10, 2021

Well. It won't work any worse than it used to work or will it?

So I would rather:

  • update Dokka
  • move things into the release profile
    as a first step as it fixes some problems we have.

And then you can continue on figuring out how things can be fixed?

@evanchooly
Copy link
Member Author

I cleaned up my overexuberance. :) There is still the one test failing on multiple PUs and I don't know why. the set up looks the same as the java side. but i'm going to go through all the dokka bits and circle back to this one.

@evanchooly evanchooly marked this pull request as ready for review May 10, 2021 22:26
@quarkus-bot
Copy link

quarkus-bot bot commented May 10, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c710e2b

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs
MicroProfile TCKs Tests Verify Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 31 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 27 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 31 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 27 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 31 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 27 - More details - Source on GitHub


⚙️ MicroProfile TCKs Tests #

📦 tcks/resteasy-reactive/target/testsuite/tests

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.returnIsInvalidForBeingOneCharLongTest line 200 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.beanAnnotatedIsInvalidForBeingFiveCharsLongTest line 253 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.beanAnnotatedReturnIsInvalidForBeingFiveCharsLongTest line 309 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.beanIsInvalidForBeingOneCharLongTest line 144 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.returnIsInvalidForBeingFiveCharsLongTest line 181 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.constraintDeclarationExceptionThrownTest line 365 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.beanIsInvalidForBeingFiveCharsLongTest line 126 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.validateExecutableIsInvalidForBeingShortTest line 236 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.beanAnnotatedIsInvalidForBeingFiveCharsLongTest line 154 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.beanAnnotatedReturnIsInvalidForBeingFiveCharsLongTest line 175 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.returnIsInvalidForBeingFiveCharsLongTest line 134 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.constraintDeclarationExceptionThrownTest line 194 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.beanIsInvalidForBeingFiveCharsLongTest line 115 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.validateExecutableIsInvalidForBeingShortTest line 234 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.beanAnnotatedIsInvalidForBeingFiveCharsLongTest line 153 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.beanAnnotatedReturnIsInvalidForBeingFiveCharsLongTest line 174 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.returnIsInvalidForBeingFiveCharsLongTest line 133 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.beanIsInvalidForBeingFiveCharsLongTest line 114 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 75f1501

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs
MicroProfile TCKs Tests Verify Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 31 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 27 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 31 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 27 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 31 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 27 - More details - Source on GitHub


⚙️ MicroProfile TCKs Tests #

📦 tcks/resteasy-reactive/target/testsuite/tests

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.returnIsInvalidForBeingOneCharLongTest line 200 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.beanAnnotatedIsInvalidForBeingFiveCharsLongTest line 253 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.beanAnnotatedReturnIsInvalidForBeingFiveCharsLongTest line 309 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.beanIsInvalidForBeingOneCharLongTest line 144 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.returnIsInvalidForBeingFiveCharsLongTest line 181 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.constraintDeclarationExceptionThrownTest line 365 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.annotation.JAXRSClient0168.beanIsInvalidForBeingFiveCharsLongTest line 126 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.validateExecutableIsInvalidForBeingShortTest line 236 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.beanAnnotatedIsInvalidForBeingFiveCharsLongTest line 154 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.beanAnnotatedReturnIsInvalidForBeingFiveCharsLongTest line 175 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.returnIsInvalidForBeingFiveCharsLongTest line 134 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.constraintDeclarationExceptionThrownTest line 194 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.constraintviolationexceptionmapper.JAXRSClient0169.beanIsInvalidForBeingFiveCharsLongTest line 115 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.validateExecutableIsInvalidForBeingShortTest line 234 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.beanAnnotatedIsInvalidForBeingFiveCharsLongTest line 153 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.beanAnnotatedReturnIsInvalidForBeingFiveCharsLongTest line 174 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.returnIsInvalidForBeingFiveCharsLongTest line 133 - More details - Source on GitHub

com.sun.ts.tests.jaxrs.platform.beanvalidation.validationexceptionmapper.JAXRSClient0170.beanIsInvalidForBeingFiveCharsLongTest line 114 - More details - Source on GitHub

@evanchooly
Copy link
Member Author

I've tried 8 different times to get rid of those extra line feeds at the end. IDEA keeps putting them there. I turned off that option but it doesn't appear to have affected this at all.

@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 9708343

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 31 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 27 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 31 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 27 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange line 31 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange line 26 - More details - Source on GitHub

io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx line 27 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 085ccc9

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/cache/deployment

io.quarkus.cache.test.devmode.CacheHotReloadTest.testHotReload line 31 - More details - Source on GitHub

📦 extensions/hibernate-validator/deployment

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testMethodConstraintHotReplacement line 73 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testNewBeanHotReplacement line 95 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testClassConstraintHotReplacement line 30 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testPropertyConstraintHotReplacement line 52 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testNewConstraintHotReplacement line 119 - More details - Source on GitHub

📦 extensions/resteasy-classic/resteasy-qute/deployment

io.quarkus.qute.resteasy.deployment.MessageBundleDevModeTest.testMessageBundles line 30 - More details - Source on GitHub

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.devmode.ConfigurationLiveReloadTest.testSubscriberCodeChange line 69 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.devmode.ConfigurationLiveReloadTest.testProcessorCodeChange line 58 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.hotreload.CodeChangeTest.testUpdatingAnnotations line 51 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.hotreload.CodeChangeTest.testUpdatingCode line 30 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector line 34 - More details - Source on GitHub

📦 extensions/spring-web/deployment

io.quarkus.spring.web.test.ControllerReloadTest.testRepositoryIsReloaded line 24 - More details - Source on GitHub

📦 extensions/undertow/deployment

io.quarkus.undertow.test.devmode.ServletChangeTestCase.testServletChange line 43 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/cache/deployment

io.quarkus.cache.test.devmode.CacheHotReloadTest.testHotReload line 31 - More details - Source on GitHub

📦 extensions/hibernate-validator/deployment

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testMethodConstraintHotReplacement line 73 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testNewBeanHotReplacement line 95 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testClassConstraintHotReplacement line 30 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testPropertyConstraintHotReplacement line 52 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testNewConstraintHotReplacement line 119 - More details - Source on GitHub

📦 extensions/resteasy-classic/resteasy-qute/deployment

io.quarkus.qute.resteasy.deployment.MessageBundleDevModeTest.testMessageBundles line 30 - More details - Source on GitHub

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.devmode.ConfigurationLiveReloadTest.testSubscriberCodeChange line 69 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.devmode.ConfigurationLiveReloadTest.testProcessorCodeChange line 58 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.hotreload.CodeChangeTest.testUpdatingAnnotations line 51 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.hotreload.CodeChangeTest.testUpdatingCode line 30 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector line 34 - More details - Source on GitHub

📦 extensions/spring-web/deployment

io.quarkus.spring.web.test.ControllerReloadTest.testRepositoryIsReloaded line 24 - More details - Source on GitHub

📦 extensions/undertow/deployment

io.quarkus.undertow.test.devmode.ServletChangeTestCase.testServletChange line 43 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/cache/deployment

io.quarkus.cache.test.devmode.CacheHotReloadTest.testHotReload line 31 - More details - Source on GitHub

📦 extensions/hibernate-validator/deployment

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testMethodConstraintHotReplacement line 73 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testNewBeanHotReplacement line 95 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testClassConstraintHotReplacement line 30 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testPropertyConstraintHotReplacement line 52 - More details - Source on GitHub

io.quarkus.hibernate.validator.test.devmode.DevModeConstraintValidationTest.testNewConstraintHotReplacement line 119 - More details - Source on GitHub

📦 extensions/resteasy-classic/resteasy-qute/deployment

io.quarkus.qute.resteasy.deployment.MessageBundleDevModeTest.testMessageBundles line 30 - More details - Source on GitHub

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.devmode.ConfigurationLiveReloadTest.testSubscriberCodeChange line 69 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.devmode.ConfigurationLiveReloadTest.testProcessorCodeChange line 58 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.hotreload.CodeChangeTest.testUpdatingAnnotations line 51 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.hotreload.CodeChangeTest.testUpdatingCode line 30 - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector line 34 - More details - Source on GitHub

📦 extensions/spring-web/deployment

io.quarkus.spring.web.test.ControllerReloadTest.testRepositoryIsReloaded line 24 - More details - Source on GitHub

📦 extensions/undertow/deployment

io.quarkus.undertow.test.devmode.ServletChangeTestCase.testServletChange line 43 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 2f0ddf6

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload - More details - Source on GitHub

📦 integration-tests/avro-reload

io.quarkus.avro.deployment.AvroCodeReloadTest.shouldAlterSchema - More details - Source on GitHub

io.quarkus.avro.deployment.AvroCodeReloadTest.shouldAlterProtocol - More details - Source on GitHub

io.quarkus.avro.deployment.AvroCodeReloadTest.shouldAlterAvdl - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload - More details - Source on GitHub

📦 integration-tests/avro-reload

io.quarkus.avro.deployment.AvroCodeReloadTest.shouldAlterSchema - More details - Source on GitHub

io.quarkus.avro.deployment.AvroCodeReloadTest.shouldAlterProtocol - More details - Source on GitHub

io.quarkus.avro.deployment.AvroCodeReloadTest.shouldAlterAvdl - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented May 12, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 57e204f

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest line 84 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload line 77 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest line 95 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload line 111 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload line 67 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest line 84 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload line 77 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest line 95 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload line 111 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload line 67 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented May 12, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d98b214

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs

@evanchooly
Copy link
Member Author

OK. so that last failure is modules related. I think we can ignore that one for now as there is already another issue filed to make jdk16 work. Agreed?

@evanchooly evanchooly dismissed gsmet’s stale review May 12, 2021 13:46

removed the entry

@evanchooly
Copy link
Member Author

bump

@gsmet
Copy link
Member

gsmet commented May 19, 2021

@evanchooly where are we on this now?

@evanchooly
Copy link
Member Author

OK. we absolutely have to remove java 16 passing as a gatekeeping feature here. Java 16 requires moving to kotlin 1.5.0 full stop. However, with 1.5.0 there are byte code changes that torpedo panache processing and so that's a larger change. IMO, the standard CI should not require Java 16 passage until Java 16 is a supported platform. I can tackle the changes in panache needed to make it all work but that's larger change and longer wait than necessary for this docs change. Can we move that Java 16 run to a separate job so we're not tied down by it for the 'main' CI runs?

@famod
Copy link
Member

famod commented May 19, 2021

Self-quote:

So AFAICS dokka can be safely disabled on Java 16+.

So why do we need to kick out the entire JDK 16 build then? Have you found more issues that you cannot exclude for JDK 16?
Just trying to understand...

@evanchooly
Copy link
Member Author

the bytecode generation changed with 1.5.0 so the panache processing needs an update.

@evanchooly evanchooly marked this pull request as ready for review May 19, 2021 22:06
@famod
Copy link
Member

famod commented May 19, 2021

Bytecode only changed with Kotlin 1.5 on Java 16 or also on Java 11?

@evanchooly
Copy link
Member Author

It seems to affect only Java 16. Tests pass on 11 but not 16. Either way, the changes can be separated in spite of what I was thinking earlier and so should be. I'm still working the other issue but it shouldn't block the dokka change or the next alpha release.

@quarkus-bot
Copy link

quarkus-bot bot commented May 20, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 027adac

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs

@gsmet
Copy link
Member

gsmet commented May 20, 2021

@evanchooly do you mind if I finalize this for my needs? We really need to get this in and I think you fixed everything I wouldn't have been able to fix myself so I could go ahead.

@evanchooly
Copy link
Member Author

The only thing left i guess is to completely disable things on Java 16. But certainly do what you need to get it done. Then I can use this as a base to fix what Java 16 things I can with kotin 1.5.

@evanchooly
Copy link
Member Author

where do we stand with this?

@gsmet
Copy link
Member

gsmet commented May 24, 2021

I iterated on a branch. Didn't have time to finish yet but should be ready for the CR1.

@evanchooly
Copy link
Member Author

but not this branch? so what happens with this PR/branch? are we done with it? is your further work available somewhere? this branch was going to be the basis for trying to get java 16 working.

@gsmet
Copy link
Member

gsmet commented May 24, 2021

I will push to this branch when it's ready (today is a holiday in France). I just fixed the conflicts, fixed a few issues and added some Maven opts.

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label May 24, 2021
@gsmet
Copy link
Member

gsmet commented May 24, 2021

@evanchooly I just pushed my changes to your branch. Even if not ideal, I think the --add-opens are specific enough that they won't hide too many other issues.

@quarkus-bot
Copy link

quarkus-bot bot commented May 24, 2021

Failing Jobs - Building a339b40

Status Name Step Test failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

@gsmet gsmet merged commit 6a198fa into quarkusio:main May 24, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 24, 2021
@evanchooly evanchooly deleted the dokka branch May 25, 2021 13:42
@famod
Copy link
Member

famod commented May 25, 2021

@gsmet It seems the EA JDK job needs those new --add-opens as well:

2021-05-25T03:20:29.6025503Z [ERROR] Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:1.4.32:kapt (kapt) on project quarkus-hibernate-orm-panache-kotlin: Compilation failure
2021-05-25T03:20:29.6036133Z [ERROR] java.lang.IllegalAccessError: class org.jetbrains.kotlin.kapt3.base.KaptContext (in unnamed module @0x244d6a9f) cannot access class com.sun.tools.javac.util.Context (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.util to unnamed module @0x244d6a9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/gradle Gradle area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/panache area/resteasy-reactive area/testing area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants