-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dokka execution to a profile #16842
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 7a1247a
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 3f5c0bf
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/panache/hibernate-orm-panache-kotlin/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/panache/hibernate-orm-panache-kotlin/deployment✖ ⚙️ JVM Tests - JDK 15 #📦 extensions/panache/hibernate-orm-panache-kotlin/deployment✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 3f5c0bf
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/panache/hibernate-orm-panache-kotlin/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/panache/hibernate-orm-panache-kotlin/deployment✖ ⚙️ JVM Tests - JDK 15 #📦 extensions/panache/hibernate-orm-panache-kotlin/deployment✖ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revisit this PR with the addition of #17009 ?
Also I added a question.
extensions/panache/hibernate-orm-panache-kotlin/runtime/pom.xml
Outdated
Show resolved
Hide resolved
@evanchooly I think we should limit this PR to its original purpose. The other changes look unrelated? |
Well, it gets tricky here. Dokka apparently doesn't work well with mixed source trees. So I thought "ill just move it all to kotlin!" Which lead to a while.host of interesting issues like missing tests compared to the Java side, etc. I van move off resolving this diffs to a different PR but there are still failures in tests to resolve. It's definitely snowballing so I might just rebranch and apply lessons learned and side step these other elements as much as I can. But it feels a bit like pulling on that one loose thread and watching the whole sweater unravel. |
Well. It won't work any worse than it used to work or will it? So I would rather:
And then you can continue on figuring out how things can be fixed? |
I cleaned up my overexuberance. :) There is still the one test failing on multiple PUs and I don't know why. the set up looks the same as the java side. but i'm going to go through all the dokka bits and circle back to this one. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building c710e2b
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/vertx-http/deployment✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/vertx-http/deployment✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/vertx-http/deployment✖ ✖ ✖ ⚙️ MicroProfile TCKs Tests #📦 tcks/resteasy-reactive/target/testsuite/tests✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 75f1501
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/vertx-http/deployment✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/vertx-http/deployment✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/vertx-http/deployment✖ ✖ ✖ ⚙️ MicroProfile TCKs Tests #📦 tcks/resteasy-reactive/target/testsuite/tests✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
I've tried 8 different times to get rid of those extra line feeds at the end. IDEA keeps putting them there. I turned off that option but it doesn't appear to have affected this at all. |
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 9708343
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/vertx-http/deployment✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/vertx-http/deployment✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/vertx-http/deployment✖ ✖ ✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 085ccc9
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/cache/deployment✖ 📦 extensions/hibernate-validator/deployment✖ ✖ ✖ ✖ ✖ 📦 extensions/resteasy-classic/resteasy-qute/deployment✖ 📦 extensions/smallrye-reactive-messaging/deployment✖ ✖ ✖ ✖ ✖ 📦 extensions/spring-web/deployment✖ 📦 extensions/undertow/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/cache/deployment✖ 📦 extensions/hibernate-validator/deployment✖ ✖ ✖ ✖ ✖ 📦 extensions/resteasy-classic/resteasy-qute/deployment✖ 📦 extensions/smallrye-reactive-messaging/deployment✖ ✖ ✖ ✖ ✖ 📦 extensions/spring-web/deployment✖ 📦 extensions/undertow/deployment✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/cache/deployment✖ 📦 extensions/hibernate-validator/deployment✖ ✖ ✖ ✖ ✖ 📦 extensions/resteasy-classic/resteasy-qute/deployment✖ 📦 extensions/smallrye-reactive-messaging/deployment✖ ✖ ✖ ✖ ✖ 📦 extensions/spring-web/deployment✖ 📦 extensions/undertow/deployment✖ |
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 2f0ddf6
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/grpc/deployment✖ ✖ ✖ ✖ ✖ ✖ 📦 integration-tests/avro-reload✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/grpc/deployment✖ ✖ ✖ ✖ ✖ ✖ 📦 integration-tests/avro-reload✖ ✖ ✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 57e204f
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/grpc/deployment✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/grpc/deployment✖ ✖ ✖ ✖ ✖ |
OK. so that last failure is modules related. I think we can ignore that one for now as there is already another issue filed to make jdk16 work. Agreed? |
bump |
@evanchooly where are we on this now? |
OK. we absolutely have to remove java 16 passing as a gatekeeping feature here. Java 16 requires moving to kotlin 1.5.0 full stop. However, with 1.5.0 there are byte code changes that torpedo panache processing and so that's a larger change. IMO, the standard CI should not require Java 16 passage until Java 16 is a supported platform. I can tackle the changes in panache needed to make it all work but that's larger change and longer wait than necessary for this docs change. Can we move that Java 16 run to a separate job so we're not tied down by it for the 'main' CI runs? |
Self-quote:
So why do we need to kick out the entire JDK 16 build then? Have you found more issues that you cannot exclude for JDK 16? |
the bytecode generation changed with 1.5.0 so the panache processing needs an update. |
Bytecode only changed with Kotlin 1.5 on Java 16 or also on Java 11? |
It seems to affect only Java 16. Tests pass on 11 but not 16. Either way, the changes can be separated in spite of what I was thinking earlier and so should be. I'm still working the other issue but it shouldn't block the dokka change or the next alpha release. |
@evanchooly do you mind if I finalize this for my needs? We really need to get this in and I think you fixed everything I wouldn't have been able to fix myself so I could go ahead. |
The only thing left i guess is to completely disable things on Java 16. But certainly do what you need to get it done. Then I can use this as a base to fix what Java 16 things I can with kotin 1.5. |
where do we stand with this? |
I iterated on a branch. Didn't have time to finish yet but should be ready for the CR1. |
but not this branch? so what happens with this PR/branch? are we done with it? is your further work available somewhere? this branch was going to be the basis for trying to get java 16 working. |
I will push to this branch when it's ready (today is a holiday in France). I just fixed the conflicts, fixed a few issues and added some Maven opts. |
@evanchooly I just pushed my changes to your branch. Even if not ideal, I think the |
@gsmet It seems the EA JDK job needs those new
|
Move the dokka executions to a profile to isolate the generation to the release execution. This also converts what little java exists in those repositories to kotlin because apparently dokka chokes on mixed-source modules.