Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dokka-maven-plugin and put it into build-parent #17355

Merged
merged 1 commit into from
May 20, 2021

Conversation

rsvoboda
Copy link
Member

Update dokka-maven-plugin from 1.4.30 to 1.4.32 and put it into build-parent.

dokka-maven-plugin was use 3 times, twice in deploy phase, once in package phase.
Now synced to deploy phase, @gsmet fyi as you did 98f655a

Update to 1.4.32 version is needed as 1.4.30 depends on kotlinx-html-jvm 0.7.2 which is not available
https://repo.maven.apache.org/maven2/org/jetbrains/kotlinx/kotlinx-html-jvm/ ... only 0.7.3 is available

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/panache area/resteasy-reactive labels May 19, 2021
@gsmet
Copy link
Member

gsmet commented May 19, 2021

A much more convoluted PR is already there: #16842

@gsmet gsmet closed this May 19, 2021
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label May 19, 2021
@rsvoboda
Copy link
Member Author

@gsmet our job to deploy Quarkus main artifacts to internal Artifactory doesn't work now because of usage of dokka 1.4.30 maven plugin which depends on kotlinx-html-jvm 0.7.2 which is not available.

If #16842 doesn't get merged within few days I would prefer reopening this PR and merging it so we can deploy Quarkus daily builds and run the community related tests in the lab.

@gsmet gsmet reopened this May 20, 2021
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label May 20, 2021
@gsmet
Copy link
Member

gsmet commented May 20, 2021

@evanchooly sorry, it will conflict with your work but we can't just wait anymore as we can't do a full release build anymore.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 20, 2021
@evanchooly
Copy link
Member

Then why not merge that other one?

@gsmet
Copy link
Member

gsmet commented May 20, 2021

Checked with the release process, let's merge. Thanks @rsvoboda !

@gsmet gsmet merged commit 8eaa066 into quarkusio:main May 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 20, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 20, 2021
@gsmet
Copy link
Member

gsmet commented May 20, 2021

@evanchooly was it ready? I kinda lost my hope on this given the information you gave me.

@quarkus-bot
Copy link

quarkus-bot bot commented May 20, 2021

🚫 This workflow run has been cancelled.

Failing Jobs - Building e84b766

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs
Native Tests - Amazon Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Cache ⚠️ Check → Logs Raw logs
Native Tests - Data1 Build ⚠️ Check → Logs Raw logs
Native Tests - Data2 Build ⚠️ Check → Logs Raw logs
Native Tests - Data3 Build ⚠️ Check → Logs Raw logs
Native Tests - Data4 Build ⚠️ Check → Logs Raw logs
Native Tests - Data6 Build ⚠️ Check → Logs Raw logs
Native Tests - Data7 Build ⚠️ Check → Logs Raw logs
Native Tests - HTTP ⚠️ Check → Logs Raw logs
Native Tests - Main Build ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 ⚠️ Check → Logs Raw logs
Native Tests - Misc1 ⚠️ Check → Logs Raw logs
Native Tests - Misc2 ⚠️ Check → Logs Raw logs
Native Tests - Misc3 ⚠️ Check → Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs
Native Tests - Security1 ⚠️ Check → Logs Raw logs
Native Tests - Security2 ⚠️ Check → Logs Raw logs
Native Tests - Security3 ⚠️ Check → Logs Raw logs
Native Tests - Spring ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator ⚠️ Check → Logs Raw logs
Native Tests - gRPC ⚠️ Check → Logs Raw logs

@gsmet gsmet modified the milestones: 2.0.0.Alpha3, 2.0 - main May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/panache area/resteasy-reactive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants