Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing deprecated BuildStep.applicationArchiveMarkers() #17018

Merged
merged 1 commit into from
May 6, 2021
Merged

Removing deprecated BuildStep.applicationArchiveMarkers() #17018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions core/deployment/src/main/java/io/quarkus/deployment/ExtensionLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
import io.quarkus.deployment.annotations.ProduceWeak;
import io.quarkus.deployment.annotations.Record;
import io.quarkus.deployment.annotations.Weak;
import io.quarkus.deployment.builditem.AdditionalApplicationArchiveMarkerBuildItem;
import io.quarkus.deployment.builditem.BootstrapConfigSetupCompleteBuildItem;
import io.quarkus.deployment.builditem.BytecodeRecorderObjectLoaderBuildItem;
import io.quarkus.deployment.builditem.ConfigurationBuildItem;
Expand Down Expand Up @@ -487,7 +486,6 @@ private static Consumer<BuildChainBuilder> loadStepsFromClass(Class<?> clazz,
method.setAccessible(true);
}
final BuildStep buildStep = method.getAnnotation(BuildStep.class);
final String[] archiveMarkers = buildStep.applicationArchiveMarkers();
final Class<? extends BooleanSupplier>[] onlyIf = buildStep.onlyIf();
final Class<? extends BooleanSupplier>[] onlyIfNot = buildStep.onlyIfNot();
final Parameter[] methodParameters = method.getParameters();
Expand Down Expand Up @@ -521,14 +519,6 @@ private static Consumer<BuildChainBuilder> loadStepsFromClass(Class<?> clazz,
}
final BooleanSupplier finalAddStep = addStep;

if (archiveMarkers.length > 0) {
chainConfig = chainConfig.andThen(bcb -> bcb.addBuildStep(bc -> {
for (String marker : archiveMarkers) {
bc.produce(new AdditionalApplicationArchiveMarkerBuildItem(marker));
}
}).produces(AdditionalApplicationArchiveMarkerBuildItem.class).buildIf(finalAddStep));
}

if (isRecorder) {
assert recordAnnotation != null;
final ExecutionTime executionTime = recordAnnotation.value();
Expand Down
14 changes: 0 additions & 14 deletions core/deployment/src/main/java/io/quarkus/deployment/annotations/BuildStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,20 +63,6 @@
@Target(ElementType.METHOD)
public @interface BuildStep {

/**
* Indicates that the provided file names should be considered to be application index markers.
*
* If these are present in library on the class path then the library will be indexed, and this index will be
* used when evaluating application components.
*
* This should not be used, {@link io.quarkus.deployment.builditem.AdditionalApplicationArchiveMarkerBuildItem}
* should just be produced directly instead.
*
* This method will be removed at some point post Quarkus 1.1.
*/
@Deprecated
String[] applicationArchiveMarkers() default {};

/**
* Only include this build step if the given supplier class(es) return {@code true}.
*
Expand Down