New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DevServices for Redis extension #17070
Add DevServices for Redis extension #17070
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of questions and suggestions.
...client/deployment/src/main/java/io/quarkus/redis/client/deployment/RedisBuildTimeConfig.java
Show resolved
Hide resolved
...client/deployment/src/main/java/io/quarkus/redis/client/deployment/RedisBuildTimeConfig.java
Show resolved
Hide resolved
...is-client/deployment/src/main/java/io/quarkus/redis/client/deployment/DevServicesConfig.java
Show resolved
Hide resolved
...is-client/deployment/src/main/java/io/quarkus/redis/client/deployment/DevServicesConfig.java
Show resolved
Hide resolved
...client/deployment/src/main/java/io/quarkus/redis/client/deployment/DevServicesProcessor.java
Show resolved
Hide resolved
...client/deployment/src/main/java/io/quarkus/redis/client/deployment/DevServicesProcessor.java
Outdated
Show resolved
Hide resolved
...client/deployment/src/main/java/io/quarkus/redis/client/deployment/DevServicesProcessor.java
Show resolved
Hide resolved
fa3e414
to
5dd99f2
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building fa3e414
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 5dd99f2
|
74c3dc4
to
bfa83fb
Compare
bfa83fb
to
4bbed8e
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building bfa83fb
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 74c3dc4
|
Closes #16714