Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DevServices for Redis extension #17070

Merged
merged 2 commits into from May 10, 2021

Conversation

machi1990
Copy link
Member

Closes #16714

@machi1990 machi1990 requested a review from geoand May 7, 2021 15:04
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/redis area/testing labels May 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 7, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/feat/fix/docs but be a proper sentence

This message is automatically generated by a bot.

@machi1990 machi1990 changed the title feat(redis): add dev services Add DevServices for Redis extension May 7, 2021
@machi1990 machi1990 requested a review from gsmet May 7, 2021 15:10
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of questions and suggestions.

@machi1990 machi1990 force-pushed the feat/add-devservices-to-redis branch from fa3e414 to 5dd99f2 Compare May 7, 2021 15:23
@quarkus-bot quarkus-bot bot added the area/core label May 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 7, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building fa3e414

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Devtools Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Devtools Tests - JDK 11 Windows ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Linux Build ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 15 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Windows ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests ⚠️ Check → Logs Raw logs
Native Tests - Data1 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Data2 ⚠️ Check → Logs Raw logs
Native Tests - Data5 ⚠️ Check → Logs Raw logs
Native Tests - Main ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 ⚠️ Check → Logs Raw logs
Native Tests - Security3 ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 7, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5dd99f2

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs
🚫 Calculate Test Jobs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}

@machi1990 machi1990 force-pushed the feat/add-devservices-to-redis branch 2 times, most recently from 74c3dc4 to bfa83fb Compare May 7, 2021 17:30
@quarkus-bot
Copy link

quarkus-bot bot commented May 7, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building bfa83fb

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Run actions/checkout@v2 ⚠️ Check → Logs Raw logs
CI Sanity Check Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 7, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 74c3dc4

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 15 Build ⚠️ Check → Logs Raw logs

@machi1990 machi1990 requested a review from gsmet May 10, 2021 07:51
@gsmet gsmet merged commit 380e568 into quarkusio:main May 10, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 10, 2021
@machi1990 machi1990 deleted the feat/add-devservices-to-redis branch May 10, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DevServices for Redis extension
4 participants