Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DevServices support for Vault extension #17083

Merged
merged 1 commit into from May 20, 2021

Conversation

kdubb
Copy link
Contributor

@kdubb kdubb commented May 7, 2021

Enables DevServices for Vault.

  • A single Vault container is supported (equivalent to the extension)
  • The configuration allows for enabling engines:
    • Transit
    • PKI

Note that due to my unfamiliarity with how DevServices worked (although it seems mostly clear now) this is implemented essentially a copy of the recent PR #17070 for Redis. If there is complexity that can be removed or the feature can be better organized I'm all ears.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/testing area/vault labels May 7, 2021
@kdubb
Copy link
Contributor Author

kdubb commented May 7, 2021

@vsevel Please review!

@quarkus-bot
Copy link

quarkus-bot bot commented May 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building be82634

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

io.quarkus.resteasy.reactive.server.test.multipart.TooLargeFormAttributeMultipartFormInputTest.test line 82 - More details - Source on GitHub

@machi1990 machi1990 added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label May 10, 2021
Copy link
Contributor

@netodevel netodevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments.
And I missed integration tests.

@kdubb kdubb force-pushed the feature/vault_devservices branch from be82634 to f572a1f Compare May 10, 2021 14:47
@kdubb
Copy link
Contributor Author

kdubb commented May 10, 2021

@machi1990 rebased

@quarkus-bot
Copy link

quarkus-bot bot commented May 10, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building f572a1f

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Linux Build Test failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Linux #

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 16 - More details - Source on GitHub

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub


⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 16 - More details - Source on GitHub

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.TestRunnerSmokeTestCase.checkTestsAreRun line 74 - More details - Source on GitHub

@machi1990 machi1990 removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label May 10, 2021
@machi1990 machi1990 requested a review from vsevel May 10, 2021 18:46
vsevel
vsevel previously requested changes May 13, 2021
Copy link
Contributor

@vsevel vsevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not familiar with dev services. I have only minor points.

@vsevel
Copy link
Contributor

vsevel commented May 13, 2021

I think it is worth adding a small paragraph in the vault's documentation.

@kdubb
Copy link
Contributor Author

kdubb commented May 13, 2021

@vsevel I've updated the docs to reference DevServices support and configuration and fixed the version inconsistency with VaultTestExtension. Also squashed and rebased to top of main.

You said you are not familiar with DevServices. Who should be merging this?

@kdubb
Copy link
Contributor Author

kdubb commented May 14, 2021

@gsmet You reviewed and merged the Redis DevServices change, can you take a look at this as well?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a couple of issues in the doc, could you have another look? Apart from that, it looks good to go, thanks.

docs/src/main/asciidoc/vault.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/vault.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/vault.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/vault.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/vault.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/vault.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/vault.adoc Outdated Show resolved Hide resolved
@kdubb kdubb force-pushed the feature/vault_devservices branch from 79823de to 3cb70e2 Compare May 17, 2021 13:35
@gsmet
Copy link
Member

gsmet commented May 17, 2021

@vsevel could you check your comments are addressed? If so, it looks good to go.

@vsevel
Copy link
Contributor

vsevel commented May 18, 2021

@vsevel could you check your comments are addressed? If so, it looks good to go.

hi @gsmet. yes, they have been.
thanks @kdubb for this contribution.

@gsmet gsmet dismissed vsevel’s stale review May 20, 2021 09:51

Comments addressed.

@gsmet gsmet merged commit d9fa227 into quarkusio:main May 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 20, 2021
@kdubb kdubb deleted the feature/vault_devservices branch May 20, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants