Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.13.5 backports 3 #17451

Merged
merged 4 commits into from
May 25, 2021
Merged

1.13.5 backports 3 #17451

merged 4 commits into from
May 25, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented May 25, 2021

Please don't merge, I will merge it myself.

@gsmet gsmet added the area/infra internal and infrastructure related issues label May 25, 2021
@gsmet gsmet self-assigned this May 25, 2021
@gsmet
Copy link
Member Author

gsmet commented May 25, 2021

@famod there's something broken with the GIB setup. This build should have been a full build given it's a backports branch and it wasn't.

@famod
Copy link
Member

famod commented May 25, 2021

First observation: GIB is still on 3.13.0 in the 1.13 branch. The Maven 3.8.1 upgrade bumped it to 3.14.1 (and there was a separate bump to 3.14.0 before that).
But I don't really think this fully explains it. Digging deeper...

@famod
Copy link
Member

famod commented May 25, 2021

I'm afraid that this has never worked as intended for pull_request events because the "branch" is something like HEAD detached at pull/99/merge in those cases.
It does work for push though.

What we'd need is something like disableIfReferenceBranchMatches (instead of disableIfBranchMatches). I wanted to do another release of GIB anyway, so I'll add this very soon.

Until then I propose to add -Dgib.disable here: https://github.com/quarkusio/quarkus/blob/1.13/.github/workflows/ci-actions-incremental.yml#L147 (but only in the 1.13 branch!)

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label May 25, 2021
@gsmet
Copy link
Member Author

gsmet commented May 25, 2021

I suppose we never caught it because we always had some BOM changes. I added a commit to disable GIB.

@famod
Copy link
Member

famod commented May 25, 2021

I suppose we never caught it because we always had some BOM changes

It happend before but since nobody checks the logs all the time, it slipped through, e.g.: https://github.com/quarkusio/quarkus/runs/2564519922?check_suite_focus=true#step:10:24

@quarkus-bot quarkus-bot bot added the area/hibernate-validator Hibernate Validator label May 25, 2021
@gsmet gsmet merged commit 761d8fd into quarkusio:1.13 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/hibernate-validator Hibernate Validator area/infra internal and infrastructure related issues area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/mongodb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants