Update gitflow-incremental-builder to 3.14.2 #17524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/infra-automation
famod
commented
May 28, 2021
| # - the current branch is a backport branch | ||
| GIB_ARGS+=" -Dgib.referenceBranch=origin/$PULL_REQUEST_BASE -Dgib.disableIfBranchMatches='.*backport.*'" | ||
| # - the current branch is a backport branch targeting some released branch like 1.10 (merge target is not main) | ||
| GIB_ARGS+=" -Dgib.referenceBranch=origin/$PULL_REQUEST_BASE -Dgib.disableIfReferenceBranchMatches='origin/\d+\.\d+'" |
There was a problem hiding this comment.
Addresses #17451 (comment)
famod
commented
May 28, 2021
| @@ -160,7 +160,7 @@ jobs: | |||
| # mvnw just for creating gib-impacted.log ("validate" should not waste much time if not incremental at all, e.g. on main) | |||
| run: | | |||
| ./mvnw -q -T1C $COMMON_MAVEN_ARGS -Dtcks -Dquickly-ci ${{ steps.get-gib-args.outputs.gib_args }} -Dgib.logImpactedTo=gib-impacted.log validate | |||
| [ -f gib-impacted.log ] && GIB_IMPACTED=$(sed "s|$(pwd)/||" gib-impacted.log) || GIB_IMPACTED='' | |||
| [ -f gib-impacted.log ] && GIB_IMPACTED=$(cat gib-impacted.log) || GIB_IMPACTED='' | |||
There was a problem hiding this comment.
Removal of repo path prefix is not required anymore due to gitflow-incremental-builder/gitflow-incremental-builder#353
|
This should also be backported to 2.0. For 1.13 I will create a specific backport PR since the workflow files differ. (Edit: see #17530) |
This was referenced May 28, 2021
gastaldi
approved these changes
May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/gitflow-incremental-builder/gitflow-incremental-builder/releases/tag/version%2F3.14.2