Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way OIDC init failures are handled - 1.13 #17662

Closed

Conversation

sberyozkin
Copy link
Member

This backports #16773 with the following differences:

  • Keeps Keycloak test resource manager as it is still needed in 1.13.x
  • Fixes OidcWiremock test resource to use a correct keycloak.url property - it has been fixed in the main as part of some other PR - it is needed for the PR related oidc-wiremock tests to pass in 1.13.x

@sberyozkin
Copy link
Member Author

I've seen Gradle tests failing in my fork as well

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 3, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c5c2d18

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Linux Build Test failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Test failures Logs Raw logs
Native Tests - Windows - hibernate-validator Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Linux #

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub


⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub

@geoand
Copy link
Contributor

geoand commented Jun 4, 2021

@glefloch do we need to backport some Gradle fix to 1.13?

@glefloch
Copy link
Member

glefloch commented Jun 4, 2021

@geoand, yes we could backport this one #17101. It only changes the order in repository declaration.

@geoand
Copy link
Contributor

geoand commented Jun 4, 2021

Sounds good.

Mind opening a PR when you have some time?

Thanks

@glefloch
Copy link
Member

glefloch commented Jun 4, 2021

yes I will open one against quarkus:1.13

@glefloch
Copy link
Member

glefloch commented Jun 7, 2021

@sberyozkin the commit fixing those tests has been backported, can you test with it?

@sberyozkin
Copy link
Member Author

@glefloch Thanks, the failures are not related, but sure, let me rebase, hopefully it will make this PR greener :-)

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

Failing Jobs - Building 30929c4

Status Name Step Test failures Logs Raw logs
Native Tests - Windows - hibernate-validator Build ⚠️ Check → Logs Raw logs

@sberyozkin
Copy link
Member Author

Looks much better now, only hibernate-validator test is failing but it is not related to this PR

@sberyozkin sberyozkin requested a review from pedroigor June 9, 2021 15:19
@sberyozkin
Copy link
Member Author

Hey Pedro @pedroigor Can you please check this backport in case it will have to be merged to 1.13 ?

@gsmet gsmet added this to the 1.13.8.Final milestone Jun 28, 2021
@gsmet gsmet changed the title Improve the way OIDC init failures are handled Improve the way OIDC init failures are handled - 1.13 Jun 28, 2021
@sberyozkin sberyozkin closed this Sep 29, 2021
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants