Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support not having any config for Panache if no real entities #1950

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Support not having any config for Panache if no real entities #1950

merged 1 commit into from
Apr 10, 2019

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 9, 2019

Fixes #1732

@gsmet gsmet requested a review from Sanne April 9, 2019 12:05
@gsmet gsmet added this to the 0.14.0 milestone Apr 9, 2019
FroMage
FroMage reviewed Apr 9, 2019
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsmet gsmet removed this from the 0.13.1 milestone Apr 9, 2019
@FroMage FroMage self-requested a review April 10, 2019 10:34
@FroMage
Copy link
Member

FroMage commented Apr 10, 2019

Unless you specifically want @Sanne 's review, we can merge this.

@Sanne Sanne merged commit 417a65c into quarkusio:master Apr 10, 2019
@Sanne
Copy link
Member

Sanne commented Apr 10, 2019

thank you both, merging :)

Definitely not going to re-review something the two of you authored/verified. How many engineers does it take for .. :D

@Sanne Sanne added this to the 0.14.0 milestone Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

@Sanne Sanne Awaiting requested review from Sanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @FroMage @Sanne