Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smallrye RM 3.13.0 with Kafka client version 3.0.0 #21847

Merged
merged 2 commits into from
Dec 5, 2021
Merged

Smallrye RM 3.13.0 with Kafka client version 3.0.0 #21847

merged 2 commits into from
Dec 5, 2021

Conversation

ozangunalp
Copy link
Contributor

  • Added snappy as provided dependency for the kafka extension, as it is now a runtime scoped dependency for kafka-clients:3.0.0
  • Removed workaround for openjdk 7 and Mac for snappy native library

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/kafka area/kafka-streams labels Dec 1, 2021
@ozangunalp ozangunalp added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 1, 2021
@ozangunalp ozangunalp marked this pull request as ready for review December 1, 2021 14:25
@ozangunalp
Copy link
Contributor Author

Test on Reactive Messaging RC release. Do not merge

@gsmet gsmet changed the title Smallrye RM 3.13.0 with Kafka client version 3.0.0 WIP - Smallrye RM 3.13.0 with Kafka client version 3.0.0 Dec 1, 2021
@geoand geoand removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 2, 2021
@ozangunalp ozangunalp changed the title WIP - Smallrye RM 3.13.0 with Kafka client version 3.0.0 Smallrye RM 3.13.0 with Kafka client version 3.0.0 Dec 2, 2021
cescoffier
cescoffier approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything we should mention in the doc?
At least, we should mention that the client uses Kafka 3.0, but is compatible with Kafka brokers 2.0.

Does the doc cover snappy?

@ozangunalp
Copy link
Contributor Author

I'll add the portion with Kafka client 3.0.
The doc portion about snappy is still correct.

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 2, 2021

Failing Jobs - Building 3889acd

Status Name Step Failures Logs Raw logs
✖ Devtools Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.HibernateOrmCodestartTest.buildAllProjectsForLocalUse line 28 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
[Run project return status is zero] 
expected: 0

@gsmet
Copy link
Member

gsmet commented Dec 5, 2021

Should this be merged now or are we waiting for something?

@cescoffier cescoffier merged commit e461982 into quarkusio:main Dec 5, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Dec 5, 2021
@evacchi evacchi mentioned this pull request Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/kafka area/kafka-streams release/noteworthy-feature
Projects
None yet
Milestone
2.6.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@ozangunalp @gsmet @cescoffier @geoand