[Docs] Add some notes about native-image flags we use #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
approved these changes
Apr 23, 2019
| a combination of all these. | ||
|
|
||
| Generally speaking the ones listed here are those most likely to affect performance metrics, but in the right | ||
| circumstances one could observe non negligible impact from the other flags too: |
There was a problem hiding this comment.
Really minor but did you really want a colon here at the end of the sentence?
There was a problem hiding this comment.
no I didn't. There was a sentence t hat I decided to remove.. Thanks!
| === Better default for Garbage Collection implementation | ||
|
|
||
| The default in GraalVM seems meant to optimise for short lived processes. Quarkus defaults to server applications, so switch: | ||
| set `-H:InitialCollectionPolicy=com.oracle.svm.core.genscavenge.CollectionPolicy$BySpaceAndTime`. |
There was a problem hiding this comment.
I wonder if there's something wrong with switch: set or if it's just me?
There was a problem hiding this comment.
what's wrong? LGTM but I'll rephrase for clarity.
|
improved based on @gsmet 's feedback, then rebased as well. |
gsmet
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.