Allow to combine the discovered and locally configured OIDC metadata #22007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
force-pushed
the
combine_discovered_configured_oidc_metadata
branch
from
e1a89ba
to
9cf7cba
Compare
sberyozkin
force-pushed
the
combine_discovered_configured_oidc_metadata
branch
from
9cf7cba
to
2f15f4f
Compare
|
Tests look OK so far |
|
OK, let me merge since the release is due tomorrow early morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22006
This PR updates
OidcRecorderto fallback to the locally provided configuration if one of the expected URLs in the discovered doc is not provided. One of theoidc-tenancytests has been updated.Also did a minor cleanup by moving a test specific wiremock stub to the test which actually requires it (while I was planning to test this PR with a missing logout URL in the discovered doc - but then changed my mind as it is useful for
OidcWiremockTestResourceto return the end session/logout url and decided to change theoidc-tenancytest where it is simpler to control it at the JAX-RSOidcResourcetest endpoint level).Making it a draft as I haven't run all the tests yet. Also CC @FroMage