-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arc - implement support for transitive interceptor bindings. #2583
Conversation
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanDeployment.java
Outdated
Show resolved
Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanDeployment.java
Outdated
Show resolved
Hide resolved
@mkouba what about now? I've altered how we look for transitive bindings - it is now aligned with CDI and only takes into consideration annotations that are bindings themselves. And I've of course added tests for that. |
8b543c2
to
8e69f27
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added one minor comment but otherwise looks really good!
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanDeployment.java
Outdated
Show resolved
Hide resolved
Provide tests for one/two levels deep bindings on both, methods and classes.
@mkouba addressed your comment |
Provide tests for one/two levels deep bindings on both, methods and classes.
Resolves #2560