-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing unsupported properties to Hibernate ORM #26128
Conversation
Yes, thanks this is a very sensible approach and resolves my concerns. One thing to remember is that some properties are applied by optional Service implementations - occasionally we override these implementations, so it's possible that some properties will be silently ignored. |
Thanks.
Right. I think this should cover it?
I didn't add a dedicated section to the documentation because I didn't want to encourage people to use this. If they really need it, it's in the configuration reference, and we can always point them to it. |
64f585e
to
e8f6bdd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e8f6bdd
to
3165949
Compare
This comment has been minimized.
This comment has been minimized.
3165949
to
1c4c41b
Compare
This comment has been minimized.
This comment has been minimized.
I'll have a closer look at test failures on Monday; I suspect some tests are having side-effects on others... |
1c4c41b
to
4ec38ce
Compare
The problem was how Anyway, that doesn't fit what we need to do in |
Failing Jobs - Building 4ec38ce
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment
📦 extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment✖
✖
|
The failing tests are unrelated, see #26251 |
Nice, thanks! |
Hello! This is a very useful addition, thanks a lot! |
Fixes #19129.
Creating as draft because this PR is based on #26126, which needs to be merged first.=> DoneIn short, this adds a configuration property which can be used like this:
IMO, the name makes it clear that such properties will not necessarily work, but the documentation makes it extra-clear:
To be even safer, setting such a property triggers a warning on startup:
Also, such properties have the lowest precedence. If Quarkus needs to set the same property as the user for whatever reason, Quarkus will win, and another warning will be displayed on startup:
I think that should address all of @Sanne's concerns?