Handle baseUri value of @RegisterRestClient #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I have to think that the Rest Client TCK would test for this (once we start running the MicroProfile TCKs against Quarkus). |
|
@gsmet is this something you think we can get into |
mkouba
approved these changes
Jun 3, 2019
|
@mkouba good to know! I'll check that out and do it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2687
I didn't add a test for this because it would have to contain either:
http://localhost:8081, but in all other tests is read via a system property)as the value of
baseUriof@RegisterRestClient.I of course manually tested with the scenario outlined in #2687, but if someone would like a test, I'm glad to add it - just let me know which one of the scenarios explained above you would prefer.