-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP Config TCK - fix a regression caused by #2629 #2743
Conversation
Let me check this out locally and run it with the tck enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and worked like a charm!
I would say we should add the TCK tests to CI, but that's just me :) |
@kenfinnigan @stuartwdouglas @cescoffier @gsmet Hey guys, who can modify the CI config? We just need to add |
@mkouba apparently, you found your answer :) |
Waiting for CI, we would need to check the output to verify the |
@mkouba Looks like the |
@geoand I don't think so. We don't want to run the tcks for Build_JDK11_Linux. Well, we could run it for this job too. But primarily for Build_Native_Linux. |
The error is:
|
Why would we add it to the native job? I suppose it couldn't hurt, but that job is very slow as it is, so I would assume it would be best not to add it there. Also in light of the error you mentioned what if we do the following: Add a new job that first does |
Build_Native_Linux is basically all-in-one JDK8 job. +1 for a new TCK-only job. But I'm not sure if that's acceptable. Would you care to communicate this? |
Sure thing. |
@cescoffier do you think we could add a new job as in CI as part of this? Do you see any reason why not to do it? |
@geoand sure, we can add more CI jobs. |
Great! @mkouba would you like to try that approach and see how it goes? |
@geoand This PR should be open for changes. It would be great if you could take this over ;-). |
@mkouba sure thing, I will take care of it later on today :) |
c19d8f5
to
d172d14
Compare
d172d14
to
126b7b6
Compare
TCKs are working, I'll merge as soon as the rest of the jobs go green |
@geoand Looks good! Thanks. |
No problem! |
Could we also enable the
tcks
profile for CI?